Closed Bug 1566674 Opened 1 year ago Closed 4 months ago

[meta] Update or remove textbox tests

Categories

(Toolkit :: XUL Widgets, task)

task
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bdahl, Unassigned)

References

Details

(Keywords: meta)

Attachments

(2 obsolete files)

In bug 1510785 I will be disabling a few textbox tests that depend on XBL. Once the elements are converted to custom elements we should no longer skip these tests.

So far the tests skipped:
textbox-multiline-default-value.xul
335628-2.xul

textbox-multiline-default-value.xul is no longer relevant after bug 1513343, it's very likely testing the wrong thing, it could be removed completely now.
335628-2.xul will need to change to test is="search-textbox", since that will be the only remaining <textbox> XUL element.

There are also a couple of reftests that will no longer be useful after bug 1513325, notably the ones testing that normal textboxes look like normal inputs:
https://searchfox.org/mozilla-central/source/editor/reftests/xul

Blocks: 1513325
No longer depends on: 1513325
Summary: Re-enable textbox tests on android → Update or remove textbox tests

This will be easier once search-textbox is no longer using the <textbox> tag

Depends on: 1581956
Depends on: 1582590
Depends on: 1586046
Depends on: 1586018
Depends on: 1586019
Depends on: 1585884
Depends on: 1586141
Attachment #9098615 - Attachment description: Bug 1566674, remove textbox from editor directory and update test cases → Bug 1566674, Replace XUL textbox with HTML input in testcases within layout directory
Attachment #9098615 - Attachment description: Bug 1566674, Replace XUL textbox with HTML input in testcases within layout directory → Bug 1566674, Replace XUL textbox with HTML input in testcases within editor directory
Attachment #9098674 - Attachment description: Bug 1566674, remove textbox from layout directory and update test cases → Bug 1566674, Replace XUL textbox with HTML input in testcases within layout directory
No longer depends on: 1510785
Depends on: 1586336

Comment on attachment 9098674 [details]
Bug 1566674, Replace XUL textbox with HTML input in testcases within layout directory

Revision D48126 was moved to bug 1586336. Setting attachment 9098674 [details] to obsolete.

Attachment #9098674 - Attachment is obsolete: true
Depends on: 1586337

Comment on attachment 9098615 [details]
Bug 1566674, Replace XUL textbox with HTML input in testcases within editor directory

Revision D48100 was moved to bug 1586337. Setting attachment 9098615 [details] to obsolete.

Attachment #9098615 - Attachment is obsolete: true
Depends on: 1586344
Attachment #9098674 - Attachment is obsolete: false

Comment on attachment 9098674 [details]
Bug 1566674, Replace XUL textbox with HTML input in testcases within layout directory

Revision D48126 was moved to bug 1586336. Setting attachment 9098674 [details] to obsolete.

Attachment #9098674 - Attachment is obsolete: true
Keywords: meta
Summary: Update or remove textbox tests → [meta] Update or remove textbox tests
Depends on: 1586831
Depends on: 1586836
Depends on: 1586859
Depends on: 1586862
Depends on: 1586877
Depends on: 1586878
Depends on: 1586883
Depends on: 1587104
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.