1586939 - Make Gecko Profiler controls also control Base Profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Currently the Base Profiler is controlled separately from the Gecko Profiler: Separate command-line env-vars (MOZ_BASE_PROFILER_...), and no popup interaction.

Gecko Profiler controls should now work on the Base Profiler as well:

• MOZ_PROFILER_... should work on the Base Profiler; MOZ_BASE_PROFILER_... to be removed.
• When the Gecko Profiler is started through the popup, new processes should automatically run the Base Profiler on startup.

The goal is for most users to only know about the profiler, and control it; Base and Gecko Profilers should be implementation details that work together behind the scene to provide an integrated profile across more of Firefox than before.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Note to self: I should take this opportunity to add tests that verify that base profiles don't get lost (like in bug 1592887).

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1586939 - Re-enable MOZ_BASE_PROFILER_STARTUP_DURATION and _INTERVAL - r?gregtatum

This env-vars were not processed because of some needed special processing, and
they were not critical.
But now we want them to be correctly read, to match the Gecko Profiler features.

Depends on D54447

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1586939 - Remove "_BASE" from most Base Profiler env-vars - r?gregtatum

Now both profilers are controlled by the same environment variables, e.g.
"MOZ_PROFILER_STARTUP" to run both profilers at startup.

The only remaining Base Profiler-specific commands are:

• MOZ_BASE_PROFILER_HELP, because the Base Profiler doesn't have the same
  capabilities as Gecko, so it may display different available features.
• MOZ_BASE_PROFILER_LOGGING, because the Base Profiler doesn't have access to
  MOZ_LOG (both the env-var and the C++ macros).

Depends on D54448

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I should wait until bug 1599015 is resolved before landing this one.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:gerald, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Next week, after the new release.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5aac83f7f4f
Re-enable MOZ_BASE_PROFILER_STARTUP_DURATION and _INTERVAL - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/922243345807
Remove "_BASE" from most Base Profiler env-vars - r=gregtatum

Comment 8

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (Bug 1586939) for causing perma bc failures in automation.py CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9222433458072c6e042ea0e1d3d1c0d604b69a0f&selectedJob=285158083

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285158083&repo=autoland&lineNumber=2150

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7541d616ff87
Backed out 2 changesets for causing perma bc failures in automation.py CLOSED TREE

Comment 10

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Note to self: Wait for bug 1607574, port it to base profiler here before combining the env-vars.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hey Gerald, as it looks like all the dependencies are fixed. I wonder if you can update the patch and land again. Or is there something else which blocks us right now?

Comment 12

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've just finished my big project (bug 1612356), so I can come back to this here soon. (Keeping the NI as reminder.)

Comment 13

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

On it.

Comment 14

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1586939 - Skip LoadLibraryEx if we're likely to hit the crash in nvd3d9wrap{,x}.dll - r?gregtatum

This is a port of bugs 1607574, 1617188, 1635823 to the Base Profiler.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1337767992
Skip LoadLibraryEx if we're likely to hit the crash in nvd3d9wrap{,x}.dll - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/1f66a6a498e5
Remove "_BASE" from most Base Profiler env-vars - r=gregtatum

Comment 16

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=BwyzMM9uRwC8CHNMMkD1gg-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=1f66a6a498e50ce2ba306bab11a841337fe9a0ec

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304066192&repo=autoland&lineNumber=38383

Backout: https://hg.mozilla.org/integration/autoland/rev/5d80811c7ee05a8098b20e00d53fb5a92dbcc643

Comment 17

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Discussed with sheriff, this bug was not the problem. They're looking for the real culprit and will reland my patches. 😌

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a9b36b0ba39
Skip LoadLibraryEx if we're likely to hit the crash in nvd3d9wrap{,x}.dll - r=gregtatum a=reland CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/8f39a30ad224
Remove "_BASE" from most Base Profiler env-vars - r=gregtatum a=reland CLOSED TREE

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9a9b36b0ba39
https://hg.mozilla.org/mozilla-central/rev/8f39a30ad224