1587008 - [Wayland/GL] Visual glitches with gl compositor during window resize

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

When Gl compositor / WebRender is enabled, Firefox window resize is not very smooth, window is flickering/jumping.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

I see the same artifacts with resizing chrome browser on XWayland, which doesn't look much as wayland/firefox specific issue.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1587008 - [Wayland/GL] Fixed visual glitches with gl compositor during window resize, r=jhorak

Recently we update egl_window size only in moz_container_size_allocate() which is leads
to visible visual glitches as moz_container_size_allocate() is not called during window resize but
after it.

We need to update egl_window size faster which is done in configure-event callback.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We may need to backport this to FF 70.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

The fix here is incomplete - does not work with e10s enabled.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

This looks like a race condition between glSwapBuffers() and wl_egl_window_resize(). glSwapBuffers() sets wl_surface and wl_buffer position for a egl_window/GdkWindow at dri2_wl_swap_buffers_with_damage() at MESA and If we call dri2_wl_swap_buffers_with_damage()/glSwapBuffers() with old wl_egl_window_resize() values then old offset/position values are used and we see the egl_window jumping around.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1587008 - [Wayland] Set EGL window size at CompositorOGL::BeginFrame, r=sotaro

wl_egl_window size must exactly march GL rendering pipeline setting.

Compositor and widget can have different window sizes during window resize when widget
is resized faster than layout can render. Firefox window is rendered misplaced then
and it's "jumping" as layout size is behind toolkit size.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1587008 - [Wayland] Get wl_egl_window size from compositor by nsWindow::SetEGLNativeWindowSize, r=jhorak

We can't set wl_egl_window from widget code as it must match GL rendering pipeline,
so let compositor to set the egl window size.

Depends on D49136

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afc6499c8f1f
[Wayland] Set EGL window size at CompositorOGL::BeginFrame, r=sotaro
https://hg.mozilla.org/integration/autoland/rev/9e610c4628e1
[Wayland] Get wl_egl_window size from compositor by nsWindow::SetEGLNativeWindowSize, r=jhorak

Comment 9

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1587008) for build bustage on src/widget/gtk/GtkCompositorWidget.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271338273&repo=autoland&lineNumber=28042

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9e610c4628e11d5374d2adae34d26a028b30bae3

Backout:
https://hg.mozilla.org/integration/autoland/rev/8dcdb516629f8c2d57630a6ad410f3d89be541b0

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5781505ae8f5
[Wayland] Set EGL window size at CompositorOGL::BeginFrame, r=sotaro
https://hg.mozilla.org/integration/autoland/rev/cb34ab7100d3
[Wayland] Get wl_egl_window size from compositor by nsWindow::SetEGLNativeWindowSize, r=jhorak

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5781505ae8f5
https://hg.mozilla.org/mozilla-central/rev/cb34ab7100d3