1589114 - [Wayland][Webrender] Resizing/maximizing window fails to render new areas

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Kestrel]

Attachment: Resized window showing black unrendered areas

STR:

1. Start with MOZ_ENABLE_WAYLAND=true and gfx.webrender.all = true on Ubuntu 19.04.
2. Resize or maximize the window.

The rendered area of the window does not grow more than the original creation size, new areas appear black.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1096a169912f7b06f1e58294b83c32ed4bc35909&tochange=5781505ae8f5240455406984b57255cf7d615e76

Regressed by Bug 1587008.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Yes, we need a similar patch to Webrender as Bug 1587008 is for GL compositor only. Sorry to break it.

Comment 4

[Jonny Mako]

This is still broken in latest nightly.

Comment 5

[Laurențiu Nicola]

Bug 1587008 also broke full-screen YouTube: the window is drawn above where it should be, with a blank part at the bottom and the top cut off. To seek in videos you need to have the mouse cursor below the seek bar on screen.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to Laurențiu Nicola from comment #5)

Bug 1587008 also broke full-screen YouTube: the window is drawn above where it should be, with a blank part at the bottom and the top cut off. To seek in videos you need to have the mouse cursor below the seek bar on screen.

Can you please file a new bug for it? Thanks.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1589114 [Wayland] Set widget EGL window size for WebRender, r=sotaro

Comment 8

[Laurențiu Nicola]

Filed bug 1591800.

Comment 9

[novenary]

(In reply to Martin Stránský [:stransky] from comment #6)

(In reply to Laurențiu Nicola from comment #5)

Bug 1587008 also broke full-screen YouTube: the window is drawn above where it should be, with a blank part at the bottom and the top cut off. To seek in videos you need to have the mouse cursor below the seek bar on screen.

Can you please file a new bug for it? Thanks.

I do believe this is the same bug. Whether it's resizing the window, full screen browsing, or full screen youtube, anything that results in a window larger than the initial size triggers the bug. Smaller windows are fine.

Comment 10

[James Edwards-Jones]

Would it make sense to temporarily revert the fix that introduced this regression? Using a tiling window manager this has left the browser unusable for a while now as only a tiny portion of each window is rendered, often preventing access to tabs and menus.

Related: https://github.com/swaywm/sway/issues/4656

Comment 11

[dano.kutka]

Workaround is to switch gfx.webrender.force-disabled to true in about:config, it is posible to do it in floating mode. It should be fixed soon

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c765fea2aff6
[Watland] Set widget EGL window size for WebRender, r=sotaro

Comment 13

[Mel]

(In reply to Pulsebot from comment #12)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c765fea2aff6
[Watland] Set widget EGL window size for WebRender, r=sotaro

^ Uh, what's Watland?

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c765fea2aff6

Comment 17

[luis.pabon]

Is there any chance this can be backported to v71?

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9104522 [details]
Bug 1589114 [Wayland] Set widget EGL window size for WebRender, r=sotaro

Beta/Release Uplift Approval Request

• User impact if declined: Firefox window resize fails on Wayland/Webrender.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed: none

Comment 19

[luis.pabon]

Legend.

Comment 20

[Pascal Chevrel:pascalc]

Comment on attachment 9104522 [details]
Bug 1589114 [Wayland] Set widget EGL window size for WebRender, r=sotaro

Minimal patch for a bug in a linux/webrender/wayland combo, low risk, uplift approved for 71 beta 6, thanks.

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/85d1ea939621

Comment 22

[Marko]

Attachment: Screenshot from 2019-11-02 14-25-13.png

This is considered fixed??

Comment 23

[novenary]

(In reply to Marko from comment #22)

Created attachment 9105971 [details]
Screenshot from 2019-11-02 14-25-13.png

This is considered fixed??

I don't use gnome, but it's working correctly for me in sway now.

Comment 24

[Kestrel]

Comment 22 looks like Bug 1593408.

Comment 25

[luis.pabon]

Working for me in sway as well on FF71b6

Comment 28

[Austin Lund]

Attachment: Wayland output offset in fullscreen mode

This is also not working for me in sway for FF71 release. The blue is the background image. The input is not displaced like the output so they don't line up. This is only in fullscreen mode and not floating mode.