1587199 - netwerk/test/unit/test_parse_content_type.js fails when run as part of the Thunderbird Xpcshell tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1531405 +++

This is similar to bug 1582086 and bug 1585193. The answer is to switch the tests off:
https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/toolkit/components/search/tests/xpcshell/xpcshell-legacyconfig.ini#66

According to Mark Banner (bug 1582086 comment #1) the tests fail since TB doesn't have telemetry, but in fact it's ought to have since bug 1427877.

Ben, can you please take a look what's going on here. We can't go around switching off tests here and there.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: Bug 1587199 - disable test_parse_content_type.js for Thunderbird.

Comment 2

[Ben Campbell]

Attachment: Bug 1587199 - Fix test_parse_content_type.js under Thunderbird.

Comment 3

[Ben Campbell]

It's a case of a test relying on a telemetry probe which isn't enabled under Thunderbird (The histogram definition for NETWORK_CROSS_ORIGIN_STYLESHEET_CONTENT_TYPE doesn't include "thunderbird" in it's "products" list).

The perfect opportunity to try out the new bypass-the-product-check-for-testing preference flag that Chris added in Bug 1579752!
The attached patch works for me, although I'm not so happy about how verbose it is. I think it's likely that quite a few more of these cases will pop up over time, so it'd be nice to keep the pref twiddling code nice and unobtrusive. Improvement ideas most welcome!

Comment 4

[Jorg K (CEST = GMT+2)]

OK, how about fixing https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/toolkit/components/search/tests/xpcshell/xpcshell-legacyconfig.ini#66 as well?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks for the comments, Valentin. I'm unsure whether to land the approved revision with the toolkit.telemetry.testing.overrideProductsCheck pref, which seems to be there for the purpose, or do the subtest disabling the "classic way" with { skip_if: () => AppConstants.MOZ_APP_NAME == "thunderbird" }.

I'll let you guys work it out.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Since you already wrote it I guess we can go ahead and land it. The probe will expire in a few releases anyway, so we'll have to remove the test eventually.

Comment 8

[Jorg K (CEST = GMT+2)]

I hope someone ran linting in this ;-) - Landed it now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51e2dc221801
Fix test_parse_content_type.js under Thunderbird. r=valentin

Comment 10

[Ben Campbell]

Attachment: Bug 1587199 - Fix test_json_cache_(good|broken).js under Thunderbird. r=valentin

Comment 11

[Ben Campbell]

Slightly more concise version for the json_cache_... tests.
I suspect the registerCleanupFunction() bit could be ditched (each test file gets it's own profile dir, and thus it's own prefs, right?).
But it seemed more polite to clean up the preference once done.

jorgk: I did run eslint over the previous patch (and this new one).

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/51e2dc221801