1587510 - TSan: data race on SystemGroupImpl::sSingleton on startup

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Christian Holler (:decoder)]

Attachment: tsan-log-035f52aed442-sSingleton.txt

See attachment for more information. It looks like we are racing on a StaticPtr here during startup.

General information about TSan, data races, etc:

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1][2].

If the bug cannot be fixed, then a compile-time or runtime suppression needs to be added.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
[2] How to miscompile programs with "benign" data races: https://www.usenix.org/legacy/events/hotpar11/tech/final_files/Boehm.pdf

Comment 1

[Aria Beingessner [:Gankra]]

Attachment: Bug 1587510 - Remove supression for seemingly fixed issue. r?decoder

Doesn't show up in a try run anymore.

Depends on D94143

Comment 2

[Andrew McCreight [:mccr8]]

It looks like SystemGroup was removed in bug 1620594.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7663e6e9cd0
Remove supression for seemingly fixed issue. r=decoder

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e7663e6e9cd0