1588194 - Add missing property use counters to Window

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Boris Zbarsky [:bzbarsky]]

Like bug 1584630 but for Window.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Due to bug 1588257 I can measure Window.defaultStatus or Window.defaultstatus but not both. I'll measure the former, but please let me know if you think the latter is more useful...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1588194 part 1. Factor out the missing property use counter code into helper functions. r=peterv

This incidentally reduces the codesize, while allowing us to call those
functions from elsewhere. The performance impact of the extra out-of-line call
is not measurable (that is, is within the noise level) on the testcase at
https://bugzilla.mozilla.org/attachment.cgi?id=9096814.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1588194 part 2. Add missing property use counters to Window. r=peterv

Comment 4

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Huh. Mike wrote a blog post about this: https://miketaylr.com/posts/2019/03/a-historical-look-at-lowercase-defaultstatus.html

Chrome's use counters say that defaultStatus is only about twice as popular as defaultstatus, but the former is the more popular one, so this seems like the right thing to instrument.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd01e6cc73d8
part 1.  Factor out the missing property use counter code into helper functions.  r=peterv
https://hg.mozilla.org/integration/autoland/rev/784c94ebc27f
part 2.  Add missing property use counters to Window.  r=peterv

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd01e6cc73d8
https://hg.mozilla.org/mozilla-central/rev/784c94ebc27f

Comment 7

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Attachment: Data collection review

Ben, can you pronounce on this review request? Note that code has landed but collection is gated by a pref so we haven't begun collection yet.

Comment 8

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9111440 [details]
Data collection review

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

This will be captured in the [probe dictionary](https://telemetry.mozilla.org/probe-dictionary/).

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, this can be turned of by disabling Telemetry in the Firefox preferences.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

These are permanent. :tdsmith is responsible.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1: Technical Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? 

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No.

9) Does the data collection use a third-party collection tool? 

No.

data-review: r+