1588464 - First bookmark search result in address bar flickers while typing

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Kestrel]

STR:

1. Make sure browser.search.separatePrivateDefault.ui.enabled = true.
2. Focus address bar and type addons mozilla firefox addon nightly tester tools (corresponds with a default bookmark) while watching the first bookmark result.

The first bookmark often flickers when a key is pressed.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6eec85211514c69e54c7b8dd715998d0414950ce&tochange=fbf1a77926c2d27e71b69ec7d3509953c1627545

Regressed by Bug 1580834.

Comment 1

[Mark Banner (:standard8)]

This seems to be the fact that we're getting (all?) search suggestions first, then the results from history. Hopefully Marco will have some ideas here...

Comment 2

[Marco Bonardo [:mak]]

The only idea I have so far is to add a delay to the search in a private window result... it's not a simple problem to solve in general, we get search results first, we add the search in pb, then other results arrive and we discover it should not be shown, thus it gets removed.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1588464 - Add a delay to Search in a private window to reduce flicker. r=Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5bff62e1640
Add a delay to Search in a private window to reduce flicker. r=Standard8

Comment 5

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1588469, Bug 1588464) for causing bc failures in browser_test_focus_urlbar.js

Changeset c5bff62e1640 was backed out because I was getting a conflict while trying to backout the culprit from Bug 1588469 as these two are working on the same files.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3a8917a857f
Add a delay to Search in a private window to reduce flicker. r=Standard8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a3a8917a857f