1580834 - Add a "Search in private window" entry in the address bar results when only search suggestions are present

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mark Banner (:standard8)]

As part of the separate search engine for Private Browsing Mode, we want to add a line in the address bar to hint at the private browsing mode.

The line should:

• Be displayed when the address bar is showing suggestions only.
• Slide in from the right to the left with the photon motion curve.
• Have a generic message if the default engines are set the same, if not, mention the different engine for private browsing mode.

Exact UX is currently TBD.

Comment 1

[KalleMP]

On Reddit or Stackexchange someone mentioned a fix for a similar question.

Basically prefixing, suffixing or embedding a question mark "?" at any point will also force a search to be performed father than a URL request.

They also mentioned a keyboard shortcut with a "K" that would place a "?" prefix and move the focus to the Addressbar.

I guess the mnemonic is K for Kwestion :-)

Comment 2

[KalleMP]

(In reply to KalleMP from comment #1)

The Fix was on SuperUser but when I tried it it just moved focus to my Searchbar and did not prefix a questionmark. Odd

https://superuser.com/questions/389136/how-can-i-disable-searching-and-domain-guessing-from-the-firefox-address-bar-wh/981279#981279

Comment 3

[Drew Willcoxon :adw]

If the search bar is visible, the shortcut will focus it. If it's not visible, the shortcut will focus the address bar with a "?" prefix. I'm not sure how your comments are related to this bug, though.

Comment 4

[KalleMP]

(In reply to Drew Willcoxon :adw from comment #3)

If the search bar is visible, the shortcut will focus it. If it's not visible, the shortcut will focus the address bar with a "?" prefix. I'm not sure how your comments are related to this bug, though.

(In reply to KalleMP from comment #2)

(In reply to KalleMP from comment #1)

Sorry, can an admin hide or delete these please.

All my comments on this bug were intended for another bug 1 4 9 2 7 3 4 but I had 4 open and got the wrong page

Comment 5

[Marco Bonardo [:mak]]

I'm splitting out the animation part because it makes this bug more streamlined, and for other reasons I'll explain in the splitted bug.
Thus I'm reducing points to 3 here, and moving 2 points to the animation part.

Comment 6

[Marco Bonardo [:mak]]

Attachment: Bug 1580834 - Add a Search in private window entry in the address bar results when only search suggestions are present

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbf1a77926c2
Add a Search in private window entry in the address bar results when only search suggestions are present r=Standard8

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fbf1a77926c2

Comment 9

[Md. Majedul islam]

I have reproduced this bug with Nightly 71.0a1 (2019-10-04) on Windows 10, 64 Bit!

This bug's fix is verified with the latest Nightly!

Build ID : 20191014095234
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0