1588469 - Turning off search suggestions in address bar also disables the entry to search in a private window

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Kestrel]

STR:

1. Set browser.urlbar.suggest.searches = false ("Show search suggestions in address bar results").
2. Type a long search term in the address bar.

Expected:

Two entries, one to search for term in current window and another to search in a private window.

Actual:

Only one entry, no option to search in a private window.

Setting browser.search.suggest.enabled = false ("Provide search suggestions") with browser.urlbar.suggest.searches = true works as expected.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1588469 - Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8

Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.

Remove a leftover .sources property from the context, that is no more used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b85a79175973
Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1588469, Bug 1588464) for causing bc failures in browser_test_focus_urlbar.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a6da6cc293d75ce8f7084c8440bc1e41da0f1a0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=%28bc&tochange=4a6da6cc293d75ce8f7084c8440bc1e41da0f1a0&fromchange=fc5ca4f1d3e0f2b1faf7c3530759abf4afef063b&selectedJob=271603489

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271603489&repo=autoland&lineNumber=2117

[task 2019-10-16T23:04:23.930Z] 23:04:23 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Selected element must be selectable! -
[task 2019-10-16T23:04:23.930Z] 23:04:23 INFO - Ensuring one-off search button focus on arrow down
[task 2019-10-16T23:04:23.930Z] 23:04:23 INFO - Buffered messages finished
[task 2019-10-16T23:04:23.931Z] 23:04:23 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out -
[task 2019-10-16T23:04:23.931Z] 23:04:23 INFO - GECKO(3800) | [Parent 4484, Main Thread] WARNING: NS_ENSURE_TRUE(!IsDefunct()) failed: file z:/build/build/src/accessible/windows/msaa/AccessibleWrap.cpp, line 1151
[task 2019-10-16T23:04:23.941Z] 23:04:23 INFO - GECKO(3800) | [Parent 4484, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x1e7ec34f2e0 (http://mzl.la/1FuID0j).: file z:/build/build/src/storage/mozStoragePrivateHelpers.cpp, line 108
[task 2019-10-16T23:04:23.991Z] 23:04:23 INFO - TEST-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Assertion count 5 is greater than expected range 0-0 assertions. -
[task 2019-10-16T23:04:24.009Z] 23:04:24 INFO - GECKO(3800) | MEMORY STAT | vsize 2104284MB | vsizeMaxContiguous 65010538MB | residentFast 336MB | heapAllocated 95MB
[task 2019-10-16T23:04:24.009Z] 23:04:24 INFO - TEST-OK | accessible/tests/browser/events/browser_test_focus_urlbar.js | took 90223ms

I also backed out changeset c5bff62e1640bcd05351d8f24cf34ef121d1197d from Bug 1588464 as i had a conflict while trying to backout b85a79175973 because of that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68614fa56268
Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/68614fa56268