1588491 - Associate session history entries with a session history object from creation

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Peter Van der Beken [:peterv]]

We need this because we need to know if the entry is going to be used with session history over IPC.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1588491 - Associate session history entries with a session history object from creation. r=smaug

Depends on D49169

Comment 2

[Alphan Chen [:alchen]]

Based on today's latest commit on ash, I still meet crash when adding shEntry in the parent process.

Thread 1 "firefox" received signal SIGSEGV, Segmentation fault.
4:01 PM 0x00007fffea53d294 in mozilla::RefPtrTraits<mozilla::dom::CrossProcessSHEntry>::AddRef (aPtr=0x7fffcd706558)
4:01 PM at /home/alphan/src/SessionHistory/ash/obj-x86_64-pc-linux-gnu/dist/include/mozilla/RefPtr.h:47
4:01 PM 47 static void AddRef(U* aPtr) { aPtr->AddRef(); }
4:01 PM (gdb) bt
4:01 PM #0 0x00007fffea53d294 in mozilla::RefPtrTraits<mozilla::dom::CrossProcessSHEntry>::AddRef(mozilla::dom::CrossProcessSHEntry*) (aPtr=0x7fffcd706558)
4:01 PM at /home/alphan/src/SessionHistory/ash/obj-x86_64-pc-linux-gnu/dist/include/mozilla/RefPtr.h:47
4:01 PM #1 0x00007fffea53d294 in RefPtr<mozilla::dom::CrossProcessSHEntry>::ConstRemovingRefPtrTraits<mozilla::dom::CrossProcessSHEntry>::AddRef(mozilla::dom::CrossProcessSHEntry*) (aPtr=0x7fffcd706558)
4:01 PM at /home/alphan/src/SessionHistory/ash/obj-x86_64-pc-linux-gnu/dist/include/mozilla/RefPtr.h:372
4:01 PM #2 0x00007fffea53d294 in RefPtr<mozilla::dom::CrossProcessSHEntry>::RefPtr(mozilla::dom::CrossProcessSHEntry*) (this=<optimized out>, aRawPtr=0x7fffcd706558)
4:01 PM at /home/alphan/src/SessionHistory/ash/obj-x86_64-pc-linux-gnu/dist/include/mozilla/RefPtr.h:107
4:01 PM #3 0x00007fffea53d294 in mozilla::dom::LoadSHEntryData::LoadSHEntryData(mozilla::dom::CrossProcessSHEntry*, mozilla::dom::BrowsingContext*, nsDocShellLoadState*) (this=<optimized out>, shEntry=0x7fffcd706558, browsingContext=0x7fffcd33d5e0, loadState=0x7fffca362a00) at /home/alphan/src/SessionHistory/ash/obj-x86_64-pc-linux-gnu/ipc/ipdl/ipdlheaders/mozilla/dom/PSHistory.h:50
4:01 PM #4 0x00007fffea53d294 in mozilla::dom::SHistoryParent::RecvReloadCurrentEntry(mozilla::dom::LoadSHEntryResult*) (this=<optimized out>, aLoadResult=0x7fffffffbd70)
4:01 PM at /home/alphan/src/SessionHistory/ash/docshell/shistory/SHistoryParent.cpp:84
4:01 PM #5 0x00007fffe72b1566 in mozilla::dom::PSHistoryParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (this=0x7fffca21d9c0, msg=..., reply=@0x7fffffffbfe8: 0x0)
4:01 PM at PSHistoryParent.cpp:734
4:01 PM #6 0x00007fffe7101cf5 in mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (this=0x7fffcd351000, msg__=..., reply__=<optimized out>)
4:01 PM at PContentParent.cpp:11742

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Bug 1588491 - Associate session history entries with a session history object from creation. Continue to allow docshells to create session history entries even if the root docshell doesn't have a session history object. r?smaug!

Depends on D49170

Comment 4

[Neha Kochar [:neha]]

Landed in ash - https://hg.mozilla.org/projects/ash/rev/ebb01f79e94a182e4886c4af5b0f27f5b7a41c4e and https://hg.mozilla.org/projects/ash/rev/2d4b06fe1f429eec844cdeba8a7faaa63bfc25ab

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a60f8caece8
Associate session history entries with a session history object from creation. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/13da9115c96b
Associate session history entries with a session history object from creation. Continue to allow docshells to create session history entries even if the root docshell doesn't have a session history object. r=smaug

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9a60f8caece8
https://hg.mozilla.org/mozilla-central/rev/13da9115c96b