1589512 - Add OS compositor interface to webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1589512 - WIP - DirectComposite + WR integration prototype.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1589512 - Part 1 - Add OS compositor interface to webrender.

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1589512 - Part 2 - Add example DirectComposite webrender integration.

Comment 4

[Markus Stange [:mstange]]

Attachment: patch to hook it up to native layers in Firefox on macOS

I've written a patch to hook it up to NativeLayers. Seems to work ok!
Partial tile repainting is obviously broken, I haven't hooked up clips so it renders wrong, vibrancy is broken (as expected), and it's pretty slow. It seems to be repainting four tiles during scrolling even on simple pages. Sometimes it tries to delete surfaces that don't exist. My window ends up with 121 layers, which seems like it's too much.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e786c07786
Part 1 - Add OS compositor interface to webrender. r=kvark,mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6cd2b2207bd
Part 2 - Add example DirectComposite webrender integration. r=kvark

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/93e786c07786
https://hg.mozilla.org/mozilla-central/rev/e6cd2b2207bd

Comment 8

[Sotaro Ikeda [:sotaro]]

:gw, gecko uses EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE in GetAndInitDisplayForWebRender(). It makes rendering upside down. But com_dc_create_window() seems not use it. Then overlay rendering becomes upside down with WR compositor on Windows. Is there a reason for the change?

• https://searchfox.org/mozilla-central/source/gfx/gl/GLLibraryEGL.cpp#160
• https://hg.mozilla.org/mozilla-central/file/e6cd2b2207bd4a3e0abe296852ac3f4cfc21a244/gfx/wr/example-compositor/compositor-windows/src/lib.cpp#l170

Comment 9

[Glenn Watson [:gw]]

I originally had that in the sample but removed it since everything was upside down. Perhaps it's not necessary when drawing into the DC surface API (not the swapchain API) since the surfaces are considered off-screen buffers?

I didn't actually check if ANGLE is doing extra work in the example without that flag, but it may just not be necessary when drawing straight into DC surfaces?

Comment 10

[Sotaro Ikeda [:sotaro]]

On Windows, we already use "DC Visual + SwapChain". From Bug 1585893, "DC Visual + DCompositionSurface" seems to work as similar coordinate to the SwapChain usage. In WR, there is a code to do Y-flip for frame buffer. Is it related to the y-flip difference?

• https://searchfox.org/mozilla-central/source/gfx/wr/webrender/src/device/gl.rs#1133

Comment 11

[Sotaro Ikeda [:sotaro]]

I checked example-compositor sample. When compositor was disabled, both with and without EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE cases, rendering results were same. If there is no EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE , copy happens at SwapChain11::swapRect(). If EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE is used, copy did not happen at SwapChain11::swapRect().

• https://searchfox.org/mozilla-central/source/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp#772

Comment 12

[Sotaro Ikeda [:sotaro]]

EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE was necessary when SwapChain was created by ANGLE. Current gecko does not request ANGLE to create a swap chain. Instead gecko creates SwapChain. Then we need to re-check if EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE is necessary for gecko.

Comment 13

[Sotaro Ikeda [:sotaro]]

With current ANGLE , it seems better to use EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE instead of EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE if it is necessary. Chromium uses EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE.