1591004 - Implement OS compositor interface on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

With Bug 1589512 , we could implement OS compositor interface on Windows.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: wip

The patch did not work well yet. Sometimes, some parts of page were rendered.

Comment 2

[Glenn Watson [:gw]]

Attachment: 0001-WIP.patch

The problem is that when we call eglMakeCurrent(), it doesn't bind the default framebuffer in all conditions. For now, I just hacked it to always bind to the default framebuffer surface (0) when binding a native surface. This seems to work fine, but is not 100% correct in all cases. I'll add a proper fix next week for this. But it should be enough to continue prototyping with :)

The other parts of the patch are to enable clips and enable the DC surface rendering. I also had to disable the static pref stuff locally, I think that was missing from your WIP patch?

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Glenn Watson [:gw] from comment #2)

The other parts of the patch are to enable clips and enable the DC surface rendering. I also had to disable the static pref stuff locally, I think that was missing from your WIP patch?

static pref "gfx.webrender.compositor" was added to change os compositor usage on/off. Doesn't it work for you? I am going to update wip patch with your patch and bug 1591346.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: wip

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: wip

Rebased.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1591004 - First pass of OS compositor implementation on Windows

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1591004 - First pass of OS compositor implementation on Windows

This implementation is off by default (behind gfx.webrender.compositor) until various bugs and inefficiencies are fixed.

Differential https://phabricator.services.mozilla.com/D51034

Comment 8

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=417cdf12b79f7c234669d970263d7164b1c216bb

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18ecc5b3d77b
First pass of OS compositor implementation on Windows r=gw

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/18ecc5b3d77b