1589850 - Remove unused msgFolderPickerOverlay.xul/dtd

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, task)

Description

[Ian Neal]

As far as I can see msgFolderPickerOverlay.xul and associated files are no longer used, so let's remove them.

Comment 1

[Ian Neal]

Attachment: Remove unused files

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: Removal of some strings

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9102715 [details] [diff] [review]
Remove unused files

Looks good. I tried to find a run filter popup but no luck. Wonder when it was used the last time. Probably before bug 878805.
msgFolderPickerOverlay.js was moved to suite in Bug 1586613. Didn't spot that it was unused. I suspect we can kill it too now?
Backport Bug 1586613 and kill it in all trees? f+ until decision.

Comment 3

[Ian Neal]

Comment on attachment 9102715 [details] [diff] [review]
Remove unused files

The plan would be to kill msgFolderPickerOverlay.js as part of the move to RDF, the first part is to kill the bits not currently in use, hence this bug being one of the dependencies for that meta bug. I see no reason to move msgFolderPickerOverlay.js for what is left of its time.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9102715 [details] [diff] [review]
Remove unused files

As discussed r/a+

Comment 5

[[e-mail]]

(In reply to Frank-Rainer Grahl from comment #2)

Looks good. I tried to find a run filter popup but no luck. Wonder when it was used the last time.
Bug 507676 removed it, but I failed to notice that the overlay was no longer necessary :-(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b9e3799ddb5
Remove unused msgFolderPickerOverlay.xul/dtd. r=frg

Comment 7

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/657fd8bb6fac578f356626d4ffb25344e86c6bf6

Comment 8

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/739243d45400a7119856c8c01cad7234d6e9d6ee