1589892 - Port |Bug 440616 Clean up Thunderbird's global scope a bit more| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, task)

Description

[Ian Neal]

Relevant parts of Bug 440616 need porting to SeaMonkey, as far as I can see that is:

• part 1 v2
• part 3 v1
• command cleanup v1

Also:

• relevant mailSession parts of Bug 852690 - Remaining conversion to mailServices.js in /mail/ and /mailnews/: message views
• Bug 495242 - cmd_close shouldn't be passed through the controllers for menu options

Comment 1

[Ian Neal]

Attachment: Part 1

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Ian Neal]

Attachment: Part 3

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 3

[Ian Neal]

Attachment: Command cleanup part 1

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 4

[Ian Neal]

Attachment: Part 1 v1.1

Missed a change needed in messageWindow.js

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9104795 [details]
Part 1 v1.1

lgtm

> /suite/mailnews/content/mail3PaneWindowCommands.js

MsgStop() is still in use afterwards:
https://dxr.mozilla.org/comm-esr60/search?q=MsgStop&redirect=false

TB no longer has it. Do you plan to remove it in a follow-up?

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9102836 [details] [diff] [review]
Command cleanup part 1

lgtm

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9102835 [details] [diff] [review]
Part 3

lgtm

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6eef2c8c1a3a
Port |Bug 440616 (part 1 v2) Clean up Thunderbird's global scope a bit more (mail session and 3pane commands)| to SeaMonkey. r=frg DONTBUILD
https://hg.mozilla.org/comm-central/rev/a5e5625c3786
Port |Bug 440616 (part 3 v1) Clean up Thunderbird's global scope a bit more| to SeaMonkey. r=frg DONTBUILD
https://hg.mozilla.org/comm-central/rev/99690c17bfc6
Port |Bug 440616 (command cleanup v1) Clean up Thunderbird's global scope a bit more| and |Bug 495242 cmd_close shouldn't be passed through the controllers for menu options| to SeaMonkey. r=frg DONTBUILD

Comment 9

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/328b908326fa7075f4930dd4b92bf94be6243b69
Port |Bug 440616 (part 1 v2) Clean up Thunderbird's global scope a bit more (mail session and 3pane commands)| to SeaMonkey.
https://hg.mozilla.org/releases/comm-esr60/rev/b066b5e8868cfc79d802338e9d03492ac5e8f502
Port |Bug 440616 (part 3 v1) Clean up Thunderbird's global scope a bit more| to SeaMonkey.
https://hg.mozilla.org/releases/comm-esr60/rev/b05f05a590f40660861152d6e31aa6b618797add
Port |Bug 440616 (command cleanup v1) Clean up Thunderbird's global scope a bit more| and |Bug 495242 cmd_close shouldn't be passed through the controllers for menu options| to SeaMonkey.

Comment 10

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b3193fac9546056efa19398d04d59a6deb0d3a53
Port |Bug 440616 (part 1 v2) Clean up Thunderbird's global scope a bit more (mail session and 3pane commands)| to SeaMonkey.
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/38c9d29da81e5e2a281a0834d2c590a00533fc55
Port |Bug 440616 (part 3 v1) Clean up Thunderbird's global scope a bit more| to SeaMonkey.
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2e870fe58548a4e537fee13fc6274871d35105d7
Port |Bug 440616 (command cleanup v1) Clean up Thunderbird's global scope a bit more| and |Bug 495242 cmd_close shouldn't be passed through the controllers for menu options| to SeaMonkey.