1594392 - The back button on about:addons UI does nothing if about:addons is opened from an addon's "Manage Extension" context menu option on the toolbar

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Itiel]

STR:

1. Have any addon placed on the toolbar
2. Right click the addon icon > Manage Extension
3. about:addons is opened, click the back button (on the about:addons UI, not the general back button)

AR:
Nothing. Also nothing is logged in the console.

ER:
Have no back button, or have it go back to the main addons view.

Comment 1

[Itiel]

(In reply to Itiel from comment #0)

ER:
Have no back button, or have it go back to the main addons view.

fwiw, before bug 1525175 the back button was absent in such scenario.

Comment 2

[David Heiberg [:dheiberg]]

This also happens on my end, was just getting ready to file this bug too. To add to this, after opening the "Manage Extension" page, clicking the "Extensions" category on the left hand menu does not load the list of extensions either. You have to click away to something like the "Recommendations" page and then click "Extensions" again to see the list of extensions.

Any ideas what might be causing this?

Comment 3

[Itiel]

(In reply to David Heiberg [:dheiberg] from comment #2)

To add to this, after opening the "Manage Extension" page, clicking the "Extensions" category on the left hand menu does not load the list of extensions either. You have to click away to something like the "Recommendations" page and then click "Extensions" again to see the list of extensions.

I can reproduce this intermediately even without having to click Manage Extension first.

Comment 4

[Mark Striemer [:mstriemer]]

(In reply to Itiel from comment #3)

(In reply to David Heiberg [:dheiberg] from comment #2)

To add to this, after opening the "Manage Extension" page, clicking the "Extensions" category on the left hand menu does not load the list of extensions either. You have to click away to something like the "Recommendations" page and then click "Extensions" again to see the list of extensions.

I can reproduce this intermediately even without having to click Manage Extension first.

This is bug 1591501 and I have a patch up for it. I think something probably changed with the XBL->XUL stuff going on and the handler stopped working. If you click on the padding (ie not the icon or text it will work, but that's clearly a bug).

I also noted in that bug that we should have a back button so I guess this regression is getting us closer to what I'd expect to happen...

Comment 5

[Mark Striemer [:mstriemer]]

Another issue with this button was found in bug 1591501 comment 11:

1. Performing the STR from a fresh new tab (which will open the detail page of the add-on in the same tab), except not clicking on the “Extensions” category button but on the Back Button, will return the user back to the new tab page
2. After clicking the Back Button once (doing Step 1 from above), the user will be back to the new tab page. Performing the mentioned STR again from the exact same new tab, will open the detail page of the add-on in a new tab and clicking on the Back Button will not work anymore
3. Opening a fresh new tab, loading a random webpage and performing the above STR, will cause the Back Button to not work anymore

Ideally clicking this button won't take you out of about:addons. The ScrollOffsets object has a Map of history IDs that could be used to check if we can safely navigate back in the history.

I don't know if sometimes navigating forwards, and sometimes back is going to be really weird here. Hiding the back button again might be the right thing to do in the end.

Comment 7

[Graham Perrin]

(In reply to Itiel from comment #0)

… Have no back button, or …

(In reply to Mark Striemer [:mstriemer] from comment #5)

… Hiding the back button …

Maybe:

• have the button present and greyed out when it's not applicable.

Comment 8

[Mark Striemer [:mstriemer]]

(In reply to Graham Perrin from comment #7)

(In reply to Itiel from comment #0)

… Have no back button, or …

(In reply to Mark Striemer [:mstriemer] from comment #5)

… Hiding the back button …

Maybe:

• have the button present and greyed out when it's not applicable.

That sounds fine to me, thanks.

Comment 9

[William Durand [:willdurand]]

Attachment: Bug 1594392 - Disable back button when there is no history in about:addons. r=mstriemer

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b6d7b964ea3
Disable back button when there is no history in about:addons. r=mstriemer

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3b6d7b964ea3

Comment 12

[Itiel]

Fixed on latest Nightly.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift or can this fix ride 77 to release?

Comment 14

[William Durand [:willdurand]]

:RyanVM I don't think we need a Beta uplift, it is a small UI fix.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:willdurand, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Miruna Curtean]

Marking this as verified fixed on Ff Nightly 77.0a1 (20200423095248) on Windows PRO 10 64-bit, macOS Catalina 10.15.4 and Ubuntu 18.04.3 LTS.
With the about:addons page already open (in focus or out of it) and after clicking from the extension's toolbar menu on Manage Extension the redirect will be performed to the extension's details section in about:addons and the back button is present and functional. When clicking on the button the user will be returned to the location which had been selected before using the Manage Extension option.
When the about:addons page is closed/ not open and the Manage Extension option is selected then the extension's details section from about:addons page will be loaded and the back button is present and greyed out. Clicking on it will return no results.