1591836 - Notification shows in Windows 10 even if "show only alarms" is set

Status: REOPENED

(Core :: Widget: Win32, defect, P2)

Description

[miroslav.vanek]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

• set win 10 notifications to "alarms only"
• open 'web.skype or fb messenger' in firefox
• send a message to the open 'web.skype or fb messenger'

Actual results:

win 10 notification pops up

Expected results:

notifications should be muted in "alarms only". Chrome behaves correctly

Comment 1

[miroslav.vanek]

Works fine in Nightly build 72.0a1 (2019-10-28)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:MattN, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Matthew N. [:MattN]]

(In reply to miroslav.vanek from comment #1)

Works fine in Nightly build 72.0a1 (2019-10-28)

Does the notification look the same on Nightly?

https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/toolkit/components/alerts/nsAlertsService.cpp#147-154 is the code that is supposed to handle this. It checks for QUNS_ACCEPTS_NOTIFICATIONS.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Jim Mathies [:jimm]]

Doesn't sounds like a widget bug. Lets look for a regression range.

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I've reproduced this bug on Win 10 on Firefox from version 65 to 73. I did not proceed with the regression after version 65 (10/22/2018) since it was so far back. I can confirm that on FF74 this bug doesn't happen and that the icon is also different. If you have any suggestions for the mozregression I will take it. I attach a picture with the difference in notifications from Nightly and previous versions.

Comment 7

[Florencia Di Ciocco, NI to vbalducci]

Attachment: notifications.png

Comment 8

[Julien Cristau [:jcristau]]

Is there a nightly-only flag that makes this different there?

Comment 9

[Matthew N. [:MattN]]

(In reply to Julien Cristau [:jcristau] from comment #8)

Is there a nightly-only flag that makes this different there?

Yes, and IMO we should really disable this since it's not actively being worked on: https://searchfox.org/mozilla-central/rev/623de665034eee43a54ff02939b61385ffd5990d/modules/libpref/init/all.js#4119-4121

rs=me to fix that.

Comment 10

[Julien Cristau [:jcristau]]

Filed bug 1614274 to turn this back off in nightly.

Comment 12

[Matthew N. [:MattN]]

Thanks to Gijs for pointing out this isn't a duplicate since the issue is with the non-Nightly behaviour.

(In reply to Jim Mathies [:jimm] from comment #5)

Doesn't sounds like a widget bug. Lets look for a regression range.

It is a Windows OS integration bug which have been considered "Widget bugs" in the past IIRC.

Comment 13

[Molly Howell (she/her) (mostly inactive)]

I think there might have been some confusion in this bug. Bug 1614274 disabled the Windows native notification system, so what that means is that XUL alerts are getting used all the time now. But I think XUL alerts are actually the kind that are affected by this bug. It isn't about the setting that comment 3 mentions, it's about the Windows 10 Focus Assist feature (or, formerly called quiet hours). Native toasts always honor focus assist, because that API handles it automatically, but our XUL alerts implementation ignores it.

It looks like to really fix this, we would need to either always use native toast notifications, or add a check of the current focus assist state to nsAlertsService::ShouldShowAlert.

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

Native toasts always honor focus assist, because that API handles it automatically, but our XUL alerts implementation ignores it.

True. This is not a Windows OS integration bug, instead this is rather a Windows OS non-integration bug. We should work on integration to fix this rather than disabling it.