1592144 - TypeError: frame is null

Status: RESOLVED DUPLICATE of bug 1594979

(DevTools :: Console, defect, P2)

Description

[David Walsh :davidwalsh]

I followed the STR from https://bugzilla.mozilla.org/show_bug.cgi?id=1582080 and saw this in the browser toolbox.

TypeError: frame is null: messages.js:248:23

Comment 1

[David Walsh :davidwalsh]

Attachment: Bug 1592144 - Only set frame logpoint if frame exists r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca55fba5a3a3
Only set frame logpoint if frame exists r=nchevobbe

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be22d9dc6a3a
Backed out changeset ca55fba5a3a3 for causing node devtools failures. CLOSED TREE

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset ca55fba5a3a3 for causing node devtools failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/be22d9dc6a3a0e17c256a1d74c918d0035e21e2a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&tochange=be22d9dc6a3a0e17c256a1d74c918d0035e21e2a&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-devtools-tests%2Cnode%28devtools%29&fromchange=02ea163551977ece2ff5250aae289dea50a1301f&selectedJob=273473181

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273473181&repo=autoland&lineNumber=602

[task 2019-10-29T13:53:19.664Z] [devtools-node-test-runner] Parse errors from the test logs
[task 2019-10-29T13:53:19.666Z] TEST-UNEXPECTED-FAIL | mocha | webconsole | Message reducer: messagesById adds a message to an empty store | Expected { id: '1', innerWindowID: null, allowRepeating: true, source: 'console-api', timeStamp: 1502884924471, type: 'log', helperType: null, level: 'log', category: null, messageText: null, parameters: [ 'foobar', 'test' ], repeatId: '{"frame":{"source":"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html","sourceId":"server1.conn0.child1/source25","line":1,"column":35,"options":{"logPoint":false}},"groupId":null,"indent":0,"level":"log","messageText":null,"parameters":["foobar","test"],"source":"console-api","type":"log","userProvidedStyles":[],"private":false,"stacktrace":null}', stacktrace: null, frame: { source: 'http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html', sourceId: 'server1.conn0.child1/source25', line: 1, column: 35, options: { logPoint: false } }, groupId: null, errorMessageName: null, exceptionDocURL: null, executionPoint: undefined, cssSelectors: '', userProvidedStyles: [], notes: null, indent: 0, prefix: '', private: false, logpointId: undefined, chromeContext: false, lastExecutionPoint: { point: { checkpoint: 0, progress: 0 }, messageCount: 1 } } to equal { id: '1', innerWindowID: null, allowRepeating: true, source: 'console-api', timeStamp: 1502884924471, type: 'log', helperType: null, level: 'log', category: null, messageText: null, parameters: [ 'foobar', 'test' ], repeatId: '{"frame":{"source":"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html","sourceId":"server1.conn0.child1/source25","line":1,"column":35},"groupId":null,"indent":0,"level":"log","messageText":null,"parameters":["foobar","test"],"source":"console-api","type":"log","userProvidedStyles":[],"private":false,"stacktrace":null}', stacktrace: null, frame: { source: 'http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html', sourceId: 'server1.conn0.child1/source25', line: 1, column: 35 }, groupId: null, errorMessageName: null, exceptionDocURL: null, executionPoint: undefined, cssSelectors: '', userProvidedStyles: [], notes: null, indent: 0, prefix: '', private: false, logpointId: undefined, chromeContext: false, lastExecutionPoint: { point: { checkpoint: 0, progress: 0 }, messageCount: 1 } }
[task 2019-10-29T13:53:19.666Z] [devtools-node-test-runner] Test suite [webconsole] failed

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

David, you might be blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1572667 in order to generate the stub.
I'll try to work on that soon.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:davidwalsh, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

I think this was handled in Bug 1594979.