1615283 - Use a shared test helper to navigate in DevTools tests

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Alexandre Poirot [:ochameau]]

Bug 1613035 tweaked the console helper (loadDocument) used to navigate to a new page.
This was done to better support navigation which spawn a new process and target.
But similar work will be necessary for all panels.
So that it would be benefitial to use a shared test helper when we want to navigate to a new URL, while a toolbox is opened.

Bug 1605763 also applied a similar code to webconsole's loadDocument and it would be nice to share a common waiting code.

We should probably track all the usages of BrowserTestUtils.loadURI and replace all these callsites with a DevTools specific helper, which would wait for toolbox's switched-target event.

Such work would probably be required when we will want to enable target-switching by default.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1615283 - Implement a shared `navigateTo` helper.

This is meant to support all needs we have when navigating to a new document,
while a toolbox is opened. When you don't have one, you should fallback
to BrowserTestUtils helpers.
It looks like, we never navigate in a background tab, so there is no need
to pass a browser element. We may introduce an optional argument if necessary.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1615283 - Use shared `navigateTo` helper instead of BrowserTestUtils.loadURI.

The netmonitor may benefit from a custom helper to open the netmonitor and navigate to an URL
as the current code forces a bit of duplication between each test.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1615283 - Migrate console from loadDocument to navigateTo.

See the first bug's changeset, we don't really need a context, but only the URL.
I choose "navigateTo" name as it aligns with other existing helper and the method on the Target actor.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1615283 - Converge random other navigation patterns to the unique navigateTo helper.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1615283 - Redirect old inspector "navigateTo" to the new shared helper.

As for the console, we don't really have to pass a context as we always
navigate in the foremost tab. We would need to pass a context if the tab was in background.

Comment 6

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly (M6) milestone

Comment 7

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ac1f478736ba5d29f8681e6ff83d53ef9a82ca6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2da062c1a88b
Implement a shared `navigateTo` helper. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a0fc038db5b6
Use shared `navigateTo` helper instead of BrowserTestUtils.loadURI. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6fc2ecf60dd1
Migrate console from loadDocument to navigateTo. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a838dc056fa9
Converge random other navigation patterns to the unique navigateTo helper. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cd53a0220c50
Redirect old inspector "navigateTo" to the new shared helper. r=nchevobbe

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2da062c1a88b
https://hg.mozilla.org/mozilla-central/rev/a0fc038db5b6
https://hg.mozilla.org/mozilla-central/rev/6fc2ecf60dd1
https://hg.mozilla.org/mozilla-central/rev/a838dc056fa9
https://hg.mozilla.org/mozilla-central/rev/cd53a0220c50