Start visited queries from an idle timer.
Categories
(Core :: DOM: Navigation, defect, P2)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Getting visited colors is relatively low priority during page load. GeckoView
was using a 250ms timer, which was somewhat arbitrary.
If this turns out not to be acceptable for desktop, we can change it to a higher
priority timer.
This enables batching queries from the content process. The lesser priority of
the queries, plus the batching that this enables on the content process I hope
will make a dent on the performance regression that bug 1506842 introduces
as-is.
We should probably introduce batching in the other direction too, both of those
are potential follow-up work.
Assignee | ||
Comment 1•3 years ago
|
||
These were unveiled by the coming patch.
We didn't use to call run_next_test for the links that expected no visits before
bug 1591717.
Assignee | ||
Comment 2•3 years ago
|
||
Getting visited colors is relatively low priority during page load. GeckoView
was using a 250ms timer, which was somewhat arbitrary.
If this turns out not to be acceptable for desktop, we can change it to a higher
priority timer.
This enables batching queries from the content process. The lesser priority of
the queries, plus the batching that this enables on the content process I hope
will make a dent on the performance regression that bug 1506842 introduces
as-is.
We should probably introduce batching in the other direction too, both of those
are potential follow-up work.
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Will land the first part separately to make sheriffs happy and close bug 1593988.
For the second I need to address some minor comments, the third still needs review.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14830ac12439 Fix some races caused by bug 1591717, and add some debugging code. r=mak
Comment 7•3 years ago
|
||
bugherder |
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4bbf56e69f3 Start visited queries from an idle timer. r=mak,lina https://hg.mozilla.org/integration/autoland/rev/b461f28b9c9e Batch content -> parent visited queries. r=mak
Comment 9•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•