1651476 - Selected Folders in the Folder pane are not highlighted when using light theme (TB 79.0b1 +)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Eckard Berberich]

Steps to reproduce:
Install Thunderbird 79.0b1-candidates/build2/ and create an account.
In the Folder Pane click with the mouse pointer on the account name or any folder name.

Expected result:
The account name or the selected folder name would be highlighted (get a specific background color).

Actual results:
There is no highlighting of the selected account or folder, whether it is in focus or not. The selected account or folder is not visually distinguished from other accounts or folders.
The same issue can be observed in the address book directory pane.

Comment 1

[Wayne Mery (:wsmwk)]

On my mac folder selection is shaded. However, I dont' see a focus ring. (perhaps it is too faint to see?)

Comment 2

[Richard Marti (:Paenglab)]

Eckard tested Thunderbird 79.0b1-candidates/build2/. So not a tb78found bug?

Comment 3

[Eckard Berberich]

You are right. Selected Folders are shaded when the "dark" or the "default" themes are used.
I forgot to mention that I still use the "light" theme.
The summary should be: Selected Folders in the Folder pane are not highlighted when the light theme is active.

Comment 4

[Eckard Berberich]

It's a new bug in TB 79.0b1.
I just vérified v78.0b4 and this issue is not present when using the light theme.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #1)

On my mac folder selection is shaded. However, I dont' see a focus ring. (perhaps it is too faint to see?)

I can reproduce this with 83 beta. I must not have used the light theme when I previously tested

regression range is https://hg.mozilla.org/releases/comm-beta/pushloghtml?fromchange=THUNDERBIRD_78_0b4_RELEASE&tochange=THUNDERBIRD_79_0b1_RELEASE&full=1

so perhaps we should suspect bug 1644730, which is listed in that regression range. But according to https://bugzilla.mozilla.org/show_bug.cgi?id=1644730#c14 this patch should have been on 78.0b2. What am I missing?

Comment 6

[Wayne Mery (:wsmwk)]

Dossy, do you see this in 78 using light Thunderbird theme?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1651476-selected-treechildren-and-remove-old-macOS-css-code.patch

See also FX bug 1594132. Since bug 1644461 the vibrancy does no more work.
I enabled the light sidebar colours for Mac too now.

Additionally I ported bug 1673321 too in this patch.

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9185058 [details] [diff] [review]
1651476-selected-treechildren-and-remove-old-macOS-css-code.patch

Review of attachment 9185058 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't seem to work for me.
I tested it on trunk and the selected folder still doesn't show an highlight background color.

Comment 9

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #8)

Comment on attachment 9185058 [details] [diff] [review]
1651476-selected-treechildren-and-remove-old-macOS-css-code.patch

Review of attachment 9185058 [details] [diff] [review]:

This doesn't seem to work for me.
I tested it on trunk and the selected folder still doesn't show an highlight
background color.

Was the light theme already selected before you built with the patch? Then you need to disable/enable the light theme to apply the theme changes. It seems there is a cached version used. I don't know how we could fix this update issue. Maybe with a theme version change to 1.1.1?

Comment 10

[Richard Marti (:Paenglab)]

Tried with the version change to 1.1.1 but this didn't work.

Comment 11

[Alessandro Castellani [:aleca]]

Comment on attachment 9185058 [details] [diff] [review]
1651476-selected-treechildren-and-remove-old-macOS-css-code.patch

Indeed, you were right. I had the light theme already selected when applying the patch.
This fixes the missing highlight color, thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c8d716c35cb0
Fix folderTree selected items and port bug 1673321: Remove theme CSS for macOS 10.11 and below. r=aleca