1594995 - Use RKV safe mode for cert_storage

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Victor Porof [:vporof][:vp]]

See https://docs.google.com/document/d/1aoVEcn1PR-W8qE2wOx0FSchO8qMpqaAzbt4pHktf-Wc for more information about the plan.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1594995 - Part 1: Update neqo dependencies to specify a rev instead of a version, and run `./mach vendor rust` on a clean central tip, r=heycam

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1594995 - Part 2: Update RKV dependency to our safe-mode feature branch, r=keeler

Depends on D52316

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1594995 - Part 3: Vendor newly added rust dependencies, r=keeler

Depends on D52317

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1594995 - Part 4: Update cert_storage to use RKV in safe mode, r=keeler

Depends on D52318

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1594995 - Part 5: Use a safe-mode database for test_cert_storage_preexisting.js, r=keeler

Depends on D52319

Comment 6

[Victor Porof [:vporof][:vp]]

Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=942f0bc7f7bf511256131ee36e7686530c9c7b55

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f65cd268b0e5
Part 1: Update neqo dependencies to specify a rev instead of a version, and run `./mach vendor rust` on a clean central tip, r=heycam
https://hg.mozilla.org/integration/autoland/rev/fc5e72bd0abf
Part 2: Update RKV dependency to our safe-mode feature branch, r=keeler
https://hg.mozilla.org/integration/autoland/rev/72a83016b340
Part 3: Vendor newly added rust dependencies, r=keeler
https://hg.mozilla.org/integration/autoland/rev/775a103cdc2c
Part 4: Update cert_storage to use RKV in safe mode, r=keeler
https://hg.mozilla.org/integration/autoland/rev/e7d3683f6809
Part 5: Use a safe-mode database for test_cert_storage_preexisting.js, r=keeler

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f65cd268b0e5
https://hg.mozilla.org/mozilla-central/rev/fc5e72bd0abf
https://hg.mozilla.org/mozilla-central/rev/72a83016b340
https://hg.mozilla.org/mozilla-central/rev/775a103cdc2c
https://hg.mozilla.org/mozilla-central/rev/e7d3683f6809

Comment 9

[Mike Hommey [:glandium]]

"warning: security/manager/ssl/cert_storage/Cargo.toml: dependency (rkv) specification is ambiguous. Only one of branch, tag or rev is allowed. This will be considered an error in future versions"

Comment 10

[Cameron McCormack (:heycam)]

Filed bug 1596642 for that.

Comment 11

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #23942 (as of Thu, 14 Nov 2019 07:12:53 GMT) ==

Improvements:

7% raptor-tp6m-instagram-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 522.75 -> 485.33
7% raptor-tp6m-google-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 604.70 -> 563.96
6% raptor-tp6m-google-restaurants-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 633.85 -> 593.30
6% raptor-tp6m-google-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 570.17 -> 534.92
5% raptor-tp6m-google-restaurants-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 706.60 -> 667.92
5% raptor-tp6m-bing-restaurants-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 595.96 -> 567.79
5% raptor-tp6m-booking-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 615.85 -> 587.79
4% raptor-tp6m-bing-restaurants-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 pgo 637.33 -> 610.92
4% raptor-tp6m-bing-restaurants-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 721.00 -> 692.42

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23942

Comment 12

[Mike Hommey [:glandium]]

BTW, I just saw that randomly while building, but this makes us build and use 2 versions of rkv, now.

Comment 13

[Victor Porof [:vporof][:vp]]

(In reply to Mike Hommey [:glandium] (high latency) from comment #12)

BTW, I just saw that randomly while building, but this makes us build and use 2 versions of rkv, now.

That’s expected, and temporary.