1596221 - Ctrl+Tab (switch tabs) does not work on Print Preview

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect, P3)

Description

[Alice0775 White]

Reproducible: always

Steps To Reproduce:

1. Open Several tabs
2. File > Print Preview
3. Press Ctrl+Tab and hold Ctrl key
   --- observe tabs preview pops up
4. Press tab key
   --- observe outline indicator is moved on tabs preview pops up
5. Release ctrl key

Actual Results
Tabs preview pops up is dismissed as expected
However, browser tab is not switched.

Expected Results:
Browser tab should be switched.

Comment 1

[Daniel Holbert [:dholbert]]

I think this is WORKSFORME at this point, in two different ways:

(In reply to Alice0775 White from comment #0)

3. Press Ctrl+Tab and hold Ctrl key
   --- observe tabs preview pops up

(1) This ctrl-tab preview feature isn't on by default anymore -- it depends on the browser.ctrlTab.sortByRecentlyUsed feature which is now disabled-by-default (as of bug 1692303), but still can be turned back on via the pref-flip.

(2) However, setting that default change aside -- even after flipping that pref and performing the STR in a fresh profile, I'm not seeing the issue anymore; I get EXPECTED RESULTS. That seems to be because of our print/print-preview UI refresh. Testing Nightly from the day that this was filed, it looks like the STR would have been triggering our legacy "full-browser-window-takeover" print-preview UI (what we had before the current tab-modal print dialog with integrated preview). So this was presumably a bug with how that old print-preview UI stomped on top of the whole browser window (possibly with tabs changing underneath it, in the STR here).