1596299 - Ensure all network requests for an http document use DocumentChannel

Status: RESOLVED WONTFIX

(Core :: Networking, task, P2)

Description

[Paul Bone [:pbone]]

We have removed fission process switching code form nsHttpChannel (Bug 1588412) and are moving to DocumentChannel, which is a more efficient way of handling process switching due to redirects. To ship fission we want all network requests for content processes to use document channel, otherwise they won't perform process switching, I think we must be missing some because this assertion sometimes fires.

In Bug 1593545 I changed the assertion to only fire if fission is enabled or if it is a debug build. We want to make sure all requests that should use document channel do (this bug) so that assertion isn't firing.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Considering the empty comment 0, I assume you want to take this yourself. If that's not the case, please ni? me to assign it to someone else.

Comment 2

[Paul Bone [:pbone]]

Hi valentin,

Opps, didn't realise I didn't type a comment 0. I wanted to leave this unassigned for now and give it a fission milestone to prioritise it as part of fission. This is something that we don't have to do today but will have to do before we ship fission. and as far as I can tell (but maybe there's an engineer more familiar with this) we don't have enough information to solve it today.

Is that okay or is it not how you triage necko bugs?

Thanks.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Paul Bone [:pbone] from comment #2)

Is that okay or is it not how you triage necko bugs?

That's OK, but thanks for adding a description to the bug. Cheers!

Comment 4

[Chris Peterson [:cpeterson]]

M6 because this bug doesn't block dogfooding (M5).

Comment 5

[Honza Bambas (:mayhemer)]

I wonder if this is the case we should use (or should not?) use docchannel, but we don't?

Comment 6

[Matt Woodrow (:mattwoodrow)]

(In reply to Honza Bambas (:mayhemer) from comment #5)

I wonder if this is the case we should use (or should not?) use docchannel, but we don't?

I think that it is! I think that's <object> with data=<document>, which is pretty similar to an <iframe>.

I think we're going to need to support process switching those with fission.

I can't find a bug for that, Kris, do you know if we have one anywhere?

Comment 7

[Kris Maglione [:kmag]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #6)

I think that it is! I think that's <object> with data=<document>, which is pretty similar to an <iframe>.

I think we're going to need to support process switching those with fission.

I can't find a bug for that, Kris, do you know if we have one anywhere?

I don't think we do, but I've been worrying about whether we do even remotely the right thing for those for a while now...

Comment 8

[Paul Bone [:pbone]]

We've removed the assertion that checked this condition.