1614524 - Make <object> and <embed> Fission-compatible

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1614524 - Part 1: Add support for process-switching object/embed loads,

By passing a weak reference back to the DocumentChannelParent into
DocumentLoadListener for object loads, we are able to handle process switching
loads by asking the content process to create a BrowsingContext, and delaying
the real process switch until it becomes available.

The load then completes as it would before, acting as a normal process-switching
subframe load.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1614524 - Part 2: Add a test for embed element process selection and navigation,

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1614524 - Part 3: Add a fission.remoteObjectEmbed pref,

With these changes, there are still a number of test failures when remote
object/embed is enabled, due to svg sizing and resource timing tests. In order
to land these changes before those features are fixed, it will be placed behind
a pref.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1614524 - Part 4: Clean up some GetDocumentBrowsingContext callers,

These callers should likely also function with <object> and <embed> loads, so
switching them to GetLoadingBrowsingContext() should be correct.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

pref disabled try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ff832978798a418401f5624247841b024044026
pref enabled try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2c0fd7af6affd4c3d48491872b2305c7307fd72

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8715208c382
Part 1: Add support for process-switching object/embed loads, r=mattwoodrow,smaug,kamidphish
https://hg.mozilla.org/integration/autoland/rev/bc8fc464a371
Part 2: Add a test for embed element process selection and navigation, r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/742fd4c3a4af
Part 3: Add a fission.remoteObjectEmbed pref, r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/0e3534673648
Part 4: Clean up some GetDocumentBrowsingContext callers, r=mattwoodrow,kamidphish

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a8715208c382
https://hg.mozilla.org/mozilla-central/rev/bc8fc464a371
https://hg.mozilla.org/mozilla-central/rev/742fd4c3a4af
https://hg.mozilla.org/mozilla-central/rev/0e3534673648