1599342 - Add hostutils for Windows host.

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, enhancement)

Description

[Makoto Kato [:m_kato]]

To run gv-junit test etc on Windows host for developers, I need hostutils for windows host. (I don't know how to upload it to tooltool...)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Unclear what to do with this bug or how important it is. I think Windows may not be the best development platform for Fennec. Most folks probably use Linux or macOS.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Stefan Arentz [:st3fan] from comment #1)

Unclear what to do with this bug or how important it is. I think Windows may not be the best development platform for Fennec. Most folks probably use Linux or macOS.

It makes things difficult for developers who normally build on Windows but want to fix bugs in GV. If we at Mozilla truly are all mobile developers now, then we need to be willing to make development environments accessible to everybody.

Comment 3

[Geoff Brown [:gbrown]]

m_kato - If you can provide instructions like https://wiki.mozilla.org/Packaging_Android_host_utilities for Windows, I bet aerickson will help you get that into tooltool.

Comment 4

[Makoto Kato [:m_kato]]

Update wiki document (https://wiki.mozilla.org/Packaging_Android_host_utilities) for Windows

Comment 5

[Andrew Erickson [:aerickson]]

Here's the ToolTool manifest for the windows hostutils build that I just created.

[
  {
    "algorithm": "sha512",
    "visibility": "public",
    "filename": "host-utils-79.0a1.en-US.win32.tar.gz",
    "unpack": true,
    "digest": "05f9d48ac73aa3e5c5433f39821df0eba85c0c6a39ec3a334d4d0e64b10e352c0d46602ef0eb93dcda744dab8715a308dd8d8d7ca51a360c64a9f7c3bb2f4eb4",
    "size": 61113183
  }
]

:m_kato, please let me know if it works. :)

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Andrew Erickson [:aerickson] from comment #5)

:m_kato, please let me know if it works. :)

Yes, it works. Thank you.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

in order to make this work I had to hack up https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/devices/android_device.py

and fix places where we do:
os.path.isfile(os.path.join(path, 'xpcshell'))

to be more like:

xpcshell_binary = 'xpcshell'
if os.name == 'nt':
    xpcshell_binary = 'xpcshell.exe'
os.path.isfile(os.path.join(path, xpcshell_binary))

I had to do that in 3 places, then ./mach test <path> would allow me to continue forward.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

:aerickson, this is marked as resolved, is there a commit reference to a repo somewhere or link to something that has changed in order to resolve this?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

and one more spot to modify in :
https://searchfox.org/mozilla-central/source/testing/mochitest/mach_commands.py#271

Comment 10

[Andrew Erickson [:aerickson]]

I thought :m_kato was going to handle that.

Comment 11

[Andrew Erickson [:aerickson]]

:jmaher, do you have that branch ready or would you like me to recreate your changes? What's an example test path to use? Are you testing on a Windows PC?

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

I don't have the code anymore, I did put it all in this bug

Comment 13

[Andrew Erickson [:aerickson]]

Attachment: Bug 1599342: add windows hostutils

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb2515ac9f5b
add windows hostutils r=jmaher,gbrown

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cb2515ac9f5b