Closed
Bug 1601633
Opened 6 years ago
Closed 6 years ago
Improve some more tests in toolkit/components/search
Categories
(Firefox :: Search, task, P1)
Firefox
Search
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
These were originally on bug 1542269 but I'm going to move them across. Here I'm fixing a couple of issues:
- In
asyncReInit
we're attempting to sometimesreset()
the search service, and then callreInit()
. This isn't right asreset()
is only designed to be called withinit()
. - There's some more tests that can use the new simplified
useTestEngines
helper function.
Assignee | ||
Comment 1•6 years ago
|
||
SearchService.reset() isn't designed to be called with reInit, but with init.
Assignee | ||
Comment 2•6 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0b52202caca
In search tests, when running asyncReInit, don't reset the search service. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/a66f3a0d195f
Switch some more search xpcshell-tests to use the useTestEngines helper function. r=mikedeboer
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a0b52202caca
https://hg.mozilla.org/mozilla-central/rev/a66f3a0d195f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•