Closed Bug 1601633 Opened 6 years ago Closed 6 years ago

Improve some more tests in toolkit/components/search

Categories

(Firefox :: Search, task, P1)

task
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 73
Iteration:
73.1 - Dec 2 - Dec 15
Tracking Status
firefox73 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

These were originally on bug 1542269 but I'm going to move them across. Here I'm fixing a couple of issues:

  • In asyncReInit we're attempting to sometimes reset() the search service, and then call reInit(). This isn't right as reset() is only designed to be called with init().
  • There's some more tests that can use the new simplified useTestEngines helper function.

SearchService.reset() isn't designed to be called with reInit, but with init.

Blocks: 1601001
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0b52202caca In search tests, when running asyncReInit, don't reset the search service. r=mikedeboer https://hg.mozilla.org/integration/autoland/rev/a66f3a0d195f Switch some more search xpcshell-tests to use the useTestEngines helper function. r=mikedeboer
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: