1602336 - Merge MediaController and TabMediaController

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

The intial reason of creating MediaController as a basic class and extend this class to TabMediaController is that we would like to have a class MediaSessionController in the future, which is used to handle media session operations.

However, I found that being a media session controller or not is actually a dynamic change, so if we implement that as a different controller, we have to create and destroy controllers and switch between them a lots of times.

Ex. the tab can be controlled by TabController in the beginning, but after we create a media session, we have to use MediaSessionController. However, if we cancel the action handlers of the media session, then we have to switch back to TabController again...

Therefore, we should merge them into one class, and handle the media session part by different methods.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1602336 - merge MediaController and TabMediaController.

The intial reason of creating MediaController as a basic class and extend this class to TabMediaController is that we would like to have a class MediaSessionController in the future, which is used to handle media session operations.

However, I found that being a media session controller or not is actually a dynamic change, so if we implement that as a different controller, we have to create and destroy controllers and switch between them a lots of times.

Ex. the tab can be controlled by TabController in the beginning, but after we create a media session, we have to use MediaSessionController. However, if we cancel the action handlers of the media session, then we have to switch back to TabController again...

Therefore, we should merge them into one class, and handle the media session part by different methods.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4144927452f
merge MediaController and TabMediaController. r=chunmin

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c4144927452f