1602526 - Spellcheck broken for words with "Umlaute" in some text editors

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[[:philipp]]

Attachment: screenshot

After the changes from bug 1571339 there are some reports about spellchecking failing to do its work properly for german words containing "Umlaute" (ä,ö,ü) on some wysiwyg text editors.

str:

• install a german dictionary: https://addons.mozilla.org/en-US/firefox/addon/german-dictionary/
• visit https://ckeditor.com/ckeditor-5/demo/ and right-click the content area to set the spelling language to german
• delete the existing content and start typing: "Wir können es"
• the correctly spelled german word "können" is labelled as misspelled - if you right-click it and accept the spelling suggestion "können" in the context menu, the input is turning into "kkönnen".

Comment 1

[Bernd]

It's fairly bugging when you see those red waved lines below words written correctly.

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: image.png

FWIW, that seems specific to German as I can't reproduce it in French

Comment 3

[[:philipp]]

Attachment: screenshot french.png

I'm seeing it in french as well while typing

Comment 4

[[:philipp]]

we're also getting the issue reported by swedish users: https://support.mozilla.org/en-US/questions/1274745 & (presumably) https://old.reddit.com/r/firefox/comments/e86atx/spell_check_tells_me_right_words_are_wrong_when/

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Makoto, your patch in bug 1571339 seems to have caused this regression, could you have a look please? Thanks.

Comment 7

[Danny Colin [:sdk]]

I've got a few reports of a similar problem with accentuated letters in french. In those cases, it's with a "é".

Twitter links:

• https://twitter.com/i/web/status/1204328922395140096
• https://twitter.com/i/web/status/1204095768786821126
• https://twitter.com/i/web/status/1204688670818816000

Comment 8

[Makoto Kato [:m_kato]]

I look this.

Comment 10

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e611311154f653b997e2cdf6c5fa89d89ee7a615

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Bug 1602526 - Part 1. Don't use implicit cast from char to uint32_t

This is regerssion by bug 1571339.

Non-ASCII character such as 0xf9 will be casted to 0xfff9 etc by implicit cast.
So I should cast from char to uint8_t or add char version fucntions.

Comment 12

[Makoto Kato [:m_kato]]

Attachment: Bug 1602526 - Part 2. Add test

Comment 13

[[:philipp]]

i can confirm that the issue is fixed in the try build from comment #10. thanks!

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:smaug, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae790b27fe0
Part 1. Don't use implicit cast from char to uint32_t r=masayuki
https://hg.mozilla.org/integration/autoland/rev/bd3843488a45
Part 2. Add test r=masayuki

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8ae790b27fe0
https://hg.mozilla.org/mozilla-central/rev/bd3843488a45