1602617 - Reuse the same MediaControlKeysEventSource but use `open()` and `close()` to control monitoring media key events

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

Fork from [1].

[1] https://phabricator.services.mozilla.com/D56449#1719419

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1602617 - part1 : add a method to check if the event source is opened.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1602617 - part2 : reuse same event source all the time.

Because we won't change platform dynamically, so we should be able to keep same the event source all the time and use Open() and Close() to control if we need to monitor media keys event or not.

Comment 3

[Marc Streckfuß [:MeFisto94]]

In theory, we could start to apply this to the Mac Event Source, by only enabling/disabling the tap in Open/Close and leave the init to the constructor (or do it in the first open call, then we can return a failure).

However I think we need to change the Mac Code in a further iteration anyway, as there is https://developer.apple.com/documentation/mediaplayer/becoming_a_now_playable_app, which seems to be the equivalent to the other two desktop APIs (Now Playing Info = Metadata, Remote Command Center Actions = Mediakeys?).

Comment 4

[Alastor Wu [:alwu]]

(In reply to Marc Streckfuß [:MeFisto94] from comment #3)

However I think we need to change the Mac Code in a further iteration anyway, as there is https://developer.apple.com/documentation/mediaplayer/becoming_a_now_playable_app, which seems to be the equivalent to the other two desktop APIs (Now Playing Info = Metadata, Remote Command Center Actions = Mediakeys?).

That will be implemented in bug 1591230, which will be landed soon.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9eb0ac18a3b
part1 : add a method to check if the event source is opened. r=MeFisto94
https://hg.mozilla.org/integration/autoland/rev/1fb1ca98f23b
part2 : reuse same event source all the time. r=MeFisto94

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f9eb0ac18a3b
https://hg.mozilla.org/mozilla-central/rev/1fb1ca98f23b