1602956 - Get layout/reftests/async-scrolling/position-fixed-iframe-{1,2}.html to pass with Fission

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I think this is because we don't handle reftest-displayport-Xs and reftest-async-scroll-Xs in out-of-process iframes in the reftest-harness. And I think Timothy has already known.

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)

I think this is because we don't handle reftest-displayport-Xs and reftest-async-scroll-Xs in out-of-process iframes in the reftest-harness. And I think Timothy has already known.

I wasn't aware of this test using using those attributes in oop iframes (because Matt only enabled that iframe in this test to be oop pretty recently), but you are correct that that was the plan the work done in bug 1593170. The initial work done for fission in the reftest harness was not intended to include supporting this feature. So we can either add support for these types of attributes in oop iframes or change the test to get around this restriction.

This also brings up the possibility that there are tests passing with fission because we don't support special reftest attributes like this in oop iframes because they are not testing the intended behaviour. So if we added support for that the tests may fail with fission when they test the intended behaviour.

Comment 4

[Timothy Nikkel (:tnikkel)]

Looked into it briefly, seems like it would not be very hard to add support for reftest-displayport-* attributes in oop iframes. I'll probably get to it if no one gets to it before me.

Comment 5

[Timothy Nikkel (:tnikkel)]

I started on this.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Any update here? If this isn't urgent maybe we should downgrade it to P3.

Comment 7

[Timothy Nikkel (:tnikkel)]

Patches are up for review in bug 1615506 and bug 1615507. (I've been putting my reftest fission patches in separate bugs so I don't have to track which patch fixes which test exactly and some tests need multiple patches, although in this case it's clear.)

Comment 8

[Timothy Nikkel (:tnikkel)]

P3 seems reasonable given that it's not tracked until the next fission milestone.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Sounds good, thanks!

Comment 10

[Neha Kochar [:neha]]

M6c because the dependencies are already in M6c.

Comment 11

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1602956. Mark layout/reftests/async-scrolling/position-fixed-iframe-{1,2}.html as passing with fission.

Depends on D62861

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8185c99690c5
Mark layout/reftests/async-scrolling/position-fixed-iframe-{1,2}.html as passing with fission.

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8185c99690c5