1615506 - Support reftest-displayport-x/y/w/h attributes in fission iframes

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1615506. Support reftest-displayport-x/y/w/h attributes in fission iframes. r=mattwoodrow,kmag

Depends on D62859

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mattwoodrow, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Timothy Nikkel (:tnikkel)]

I guess the bot hasn't learned of review comments? :)

Comment 6

[Chris Peterson [:cpeterson]]

tnikkel, is this bug fixed?

Your Phabricator review in comment 1 points to fixes for bug 1615504 and bug 1615505. Lando says those fixes landed back in February, but fixes landed that linked to this bug:

https://lando.services.mozilla.com/D62860/

Comment 7

[Timothy Nikkel (:tnikkel)]

(In reply to Chris Peterson [:cpeterson] from comment #6)

tnikkel, is this bug fixed?

No, it's not fixed.

Your Phabricator review in comment 1 points to fixes for bug 1615504 and bug 1615505. Lando says those fixes landed back in February, but fixes landed that linked to this bug:

https://lando.services.mozilla.com/D62860/

The patches for those different bugs were in my patch queue all at the same time when I submitted them to phab, so phab created a dependency chain that doesn't necessarily reflect reality (ie the patches could be landed independently and in a different order). Although this bug is visible at that link I don't believe anything at that link indicates that these changesets have landed, they are still pending in phab.

Comment 8

[Neha Kochar [:neha]]

Timothy, can you please address the nits from kmag's review on https://phabricator.services.mozilla.com/D62860 and land it? And is this going to land together with the patch for bug 1615507?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/170e1f31f137
Support reftest-displayport-x/y/w/h attributes in fission iframes. r=mattwoodrow,kmag

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/170e1f31f137