1603270 - Add Probes for Transition Messaging

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[athomas]

Vision
Telemetry has been updated to reflect new messaging to display on the new tab banner

Acceptance Criteria

• Clicking on the "Learn More" button on the new tab banner with the transition message send a telemetry event & Leanplum event reflecting the action
• Clicking the X to close the new tab banner with the transition message sends a telemetry event & Leanplum event reflecting the action
• Changes have gone through data review

Design
Mocks
Specs

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1603270 - Add telemetry for FirefoxPromoBannerRow user actions; r?VladBaicu

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1603270 - Document the new uitelemetry and mma probes; r?VladBaicu

Depends on D58431

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Fennec - Firefox promo banner - telemetry data review form.txt

Bug 1603275 added a new banner on Fennec's awesomescreen in regards to the Fennec -> Fenix transition.
We would like to log user interactions with it.

Comment 4

[Chenxia Liu [:liuche]]

One request here: @petru is this code still in the right place in the tree? I know that (at least some of) the Fennec code is now in mozilla-esr68. I don't see uitelemetry.rst being published publicly anymore (although mma.rst is) so can you move uitelemetry.rst files to the same place as https://searchfox.org/mozilla-esr68/source/mobile/android/docs/mma.rst ? The goal is that uitelemetry.rst will show up like https://firefox-source-docs.mozilla.org/mobile/android/mma.html

See https://bugzilla.mozilla.org/show_bug.cgi?id=1591287

Data-review+

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in this patch to uitelemetry.rst and mma.rst, which will be published to https://firefox-source-docs.mozilla.org/mobile/android/mma.html and https://firefox-source-docs.mozilla.org/mobile/android/uitelemetry.html

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fennec telemetry settings

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Temporary, will be removed once Fennec EOL in Aug 2020

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2

5. Is the data collection request for default-on or default-off?

Default off for release

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

No

8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, will expire

9. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Thanks Chenxia!
I've filed bug 1606806 to make uitelemetry user documentation publicly available and resolved it there since that needed changes on m-c.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Please help test the telemetry against this try build based off the most recent esr68 tree.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e7108cf7a09a22f20ec5997030262ba15650c77

Comment 7

[Petru-Mugurel Lingurar [:petru]]

When trying to test this Eliza raised an important issue:
Treeherder doesn't build release and this feature is only to work on release.
After confirming with her I made a local build - https://drive.google.com/file/d/1j1D58y5NdhZ-ItsVMiYWnegdVB-Biocm which would help on testing this before it actually getting into release.

Comment 8

[Laurentiu Apahidean]

I tested the issue using the build from comment 7 on a OnePlus 6T (Android 9). The 'firefox_promo_open' and 'firefox_promo_dismiss' events are correctly displayed in the about:telemetry -> Raw JSON section. I could not verify the Leanplum events due to the fact that I do not have access to Leanplum Release events.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9118161 [details]
Bug 1603270 - Add telemetry for FirefoxPromoBannerRow user actions; r?VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Important new feature for the Fennec -> Fenix transition
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Verified by QA
• String or UUID changes made by this patch:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9118161 [details]
Bug 1603270 - Add telemetry for FirefoxPromoBannerRow user actions; r?VladBaicu

Needed for Fennec->Fenix migration. Approved for 68.5b2.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/72a03081d967
https://hg.mozilla.org/releases/mozilla-esr68/rev/a01bb8072152

Comment 12

[Laurentiu Apahidean]

I tested the issue on RC 68.5.0 using a Samsung Galaxy Note9 (Android 9). The 'firefox_promo_open' and 'firefox_promo_dismiss' events are correctly displayed in the about:telemetry -> Raw JSON section. I could not verify the Leanplum events due to the fact that I do not have access to Leanplum Release events. I will mark this issue as verified.