1603765 - Split console browser.ini in multiple manifest files

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

I was told in Bug 1603477 that the console browser.ini was quite large, which was causing timeout on some platforms.

Splitting the manifest into multiple files might help, so let's see if we can do this.
We can probably try to have manifests for:

• browser console tests
• jsterm/autocomplete tests
• the rest

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1603765 - Split console browser.ini into multiple manifest files. r=Honza.

The mochitest-devtools-chrome can exceed its max-run-time
because the webconsole tests are only declared in one big
manifest file.
This patch split the manifest in 3 files:

• one for the browser console and browser toolbox console tests
• one for the jsterm tests
• one for the other console tests

These files are not split eavenly, but that's probably enough
for the mochitest-devtools-chrome to not be too long.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ac818e0f322
Split console browser.ini into multiple manifest files. r=Honza.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 9ac818e0f322 (Bug 1603765) for devtools/client/webconsole/test/browser/browser_jsterm_* failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Linux%2Cx64%2Cdebug%2CMochitests%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-e10s-3%2CM%28dt3%29&fromchange=b049edb3d213d8d23c0c4eadb519921886ba2224&tochange=b4b88897ba09c7deb1c46aca6b9fbd3874899085&selectedJob=284354907

Backout link: https://hg.mozilla.org/integration/autoland/rev/b4b88897ba09c7deb1c46aca6b9fbd3874899085

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284354907&repo=autoland&lineNumber=56121

...
[task 2020-01-10T10:31:57.403Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | popup has expected items -
[task 2020-01-10T10:31:57.404Z] 10:31:57 INFO - Checking jsterm state:
[task 2020-01-10T10:31:57.405Z] 10:31:57 INFO - window.foo.bar.baz[|
[task 2020-01-10T10:31:57.405Z] 10:31:57 INFO - Buffered messages finished
[task 2020-01-10T10:31:57.405Z] 10:31:57 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | console input has expected value - Got window.foo.bar.baz[], expected window.foo.bar.baz[
[task 2020-01-10T10:31:57.406Z] 10:31:57 INFO - Stack trace:
[task 2020-01-10T10:31:57.406Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-10T10:31:57.406Z] 10:31:57 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkInputValueAndCursorPosition:696
[task 2020-01-10T10:31:57.406Z] 10:31:57 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js:null:101
[task 2020-01-10T10:31:57.407Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-10T10:31:57.407Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-10T10:31:57.407Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-10T10:31:57.407Z] 10:31:57 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-10T10:31:57.409Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct line -
[task 2020-01-10T10:31:57.409Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct ch -
[task 2020-01-10T10:31:57.410Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | confirm tooltip is now closed -
[task 2020-01-10T10:31:57.410Z] 10:31:57 INFO - Checking jsterm state:
[task 2020-01-10T10:31:57.410Z] 10:31:57 INFO - window.foo.bar.baz["hello"]|
[task 2020-01-10T10:31:57.411Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | console input has expected value -
[task 2020-01-10T10:31:57.411Z] 10:31:57 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct line -
[task 2020-01-10T10:31:57.412Z] 10:31:57 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-10T10:31:57.413Z] 10:31:57 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct ch - Got 26, expected 27
[task 2020-01-10T10:31:57.413Z] 10:31:57 INFO - Stack trace:
[task 2020-01-10T10:31:57.413Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-10T10:31:57.413Z] 10:31:57 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkInputValueAndCursorPosition:701
[task 2020-01-10T10:31:57.414Z] 10:31:57 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js:null:107
[task 2020-01-10T10:31:57.414Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-10T10:31:57.414Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-10T10:31:57.414Z] 10:31:57 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-10T10:31:57.414Z] 10:31:57 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-10T10:31:57.415Z] 10:31:57 INFO - Check that autocompletion work on a getter result
[task 2020-01-10T10:31:58.460Z] 10:31:58 INFO - GECKO(2705) | [Child 2839: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f6038f16100) [pid = 2839] [serial = 30] [outer = (nil)] [url = about:blank]
...

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

mh, the failures are the ones that were caused by Bug 1582693 backed-out patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc3cfee4a014
Split console browser.ini into multiple manifest files. r=Honza.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cc3cfee4a014