Closed Bug 1604066 Opened 11 months ago Closed 10 months ago

PerformanceObserver.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: Sylvestre, Assigned: robert.m.rico, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1603696 +++

+++ This bug was initially created as a clone of Bug #1603690 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/performance/PerformanceObserver.cpp#156

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

suyash, do you want to give it a try?

Flags: needinfo?(suyash.mathur)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #1)

suyash, do you want to give it a try?

Yes, I'd love to give it a try.

Flags: needinfo?(suyash.mathur)

sure, please propose a patch then :)

Also, in the link here
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Mercurial is the version control software being used. However, can we use git for the same?

yeah, we have been working on updating the doc for git:
https://phabricator.services.mozilla.com/D55147

Is this up for grabs?

Yes Rob!

Assignee: nobody → robert.m.rico
Status: NEW → ASSIGNED
Attachment #9120458 - Attachment description: Bug 1605263 - Fixes #1605263 - Parser.cpp | parseInfo_ change r=mgaudet → Bug 1604066 - Fixes #1605263 - Parser.cpp | parseInfo_ change r=Sylvestre

Comment on attachment 9120458 [details]
Bug 1604066 - Fixes #1605263 - Parser.cpp | parseInfo_ change r=Sylvestre

Revision D59654 was moved to bug 1605263. Setting attachment 9120458 [details] to obsolete.

Attachment #9120458 - Attachment is obsolete: true

I seem to have muddied the history.

Let me know if I need to start over or how we can get these incorrect comments out.

Thanks!

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/425b79df2949
Removing Return on Void Statement in PerformanceOberserver::ReportUnsupportedTypesErrorToConsole() r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.