1604066 - PerformanceObserver.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1603696 +++

+++ This bug was initially created as a clone of Bug #1603690 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/performance/PerformanceObserver.cpp#156

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Sylvestre Ledru [:Sylvestre]]

suyash, do you want to give it a try?

Comment 2

[Suyash Vardhan Mathur]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #1)

suyash, do you want to give it a try?

Yes, I'd love to give it a try.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

sure, please propose a patch then :)

Comment 4

[Suyash Vardhan Mathur]

Also, in the link here
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Mercurial is the version control software being used. However, can we use git for the same?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

yeah, we have been working on updating the doc for git:
https://phabricator.services.mozilla.com/D55147

Comment 6

[Sylvestre Ledru [:Sylvestre]]

the git doc landed: https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 7

[Rob]

Is this up for grabs?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Yes Rob!

Comment 9

[Rob]

Attachment: Bug 1604066 - Fixes #1605263 - Parser.cpp | parseInfo_ change r=Sylvestre

Comment 10

[Rob]

Attachment: Bug 1604066 - Removing Return on Void Statement in PerformanceOberserver::ReportUnsupportedTypesErrorToConsole() r=Sylvestre

Depends on D59654

Comment 11

[Phabricator Automation]

Comment on attachment 9120458 [details]
Bug 1604066 - Fixes #1605263 - Parser.cpp | parseInfo_ change r=Sylvestre

Revision D59654 was moved to bug 1605263. Setting attachment 9120458 [details] to obsolete.

Comment 12

[Rob]

I seem to have muddied the history.

Let me know if I need to start over or how we can get these incorrect comments out.

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425b79df2949
Removing Return on Void Statement in PerformanceOberserver::ReportUnsupportedTypesErrorToConsole() r=sylvestre

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/425b79df2949