Closed Bug 1604600 Opened 10 months ago Closed 10 months ago

StructuredSpewer.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: manish.giri.me, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1603696 +++

+++ This bug was initially created as a clone of Bug #1603690 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/js/src/util/StructuredSpewer.cpp#83

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Can I claim this bug? This one is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1603696, and since I'm already working on that one, the workflow will be familiar.

Thank You

Please focus on the other one first (and no need to reply on the whole message)
thanks!

Sorry about that.

I have submitted a patch (I think that's what the change is called?) for the other one. I can work on this one too if you approve. Thank You..

Assignee: nobody → manish.giri.me
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfbb66b2621f
Remove redundant return in void function. r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.