1604600 - StructuredSpewer.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1603696 +++

+++ This bug was initially created as a clone of Bug #1603690 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/js/src/util/StructuredSpewer.cpp#83

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Manish Giri]

Can I claim this bug? This one is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1603696, and since I'm already working on that one, the workflow will be familiar.

Thank You

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Please focus on the other one first (and no need to reply on the whole message)
thanks!

Comment 3

[Manish Giri]

Sorry about that.

I have submitted a patch (I think that's what the change is called?) for the other one. I can work on this one too if you approve. Thank You..

Comment 4

[Manish Giri]

Attachment: Bug 1604600-Remove redundant return in void function. r=sylvestre

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfbb66b2621f
Remove redundant return in void function. r=sylvestre

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dfbb66b2621f