Closed Bug 1605729 Opened 8 months ago Closed 3 months ago

Extend variables.py to understand gitlab repos

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

At the moment build/variables.py assumes all repos use rev to separate changeset from repo URL. gitlab uses tree

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: link to repo is incorrect in about:buildconfig
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9117547 - Flags: review?(frgrahl)
Attachment #9117547 - Flags: approval-comm-release?
Attachment #9117547 - Flags: approval-comm-esr60?
Comment on attachment 9117547 [details] [diff] [review]
Patch variables.py [Checked in: 2.53.1 beta 1]

LGTM
Attachment #9117547 - Flags: review?(frgrahl)
Attachment #9117547 - Flags: review+
Attachment #9117547 - Flags: approval-comm-release?
Attachment #9117547 - Flags: approval-comm-release+
Attachment #9117547 - Flags: approval-comm-esr60?
Attachment #9117547 - Flags: approval-comm-esr60+

The other option is to backport 2nd and 4th parts of Bug 1507754, Bug 1578806 and Bug 1561782 then adapt source_repos.py for use against gitlab but perhaps that is for beta 2.

Comment on attachment 9117547 [details] [diff] [review]
Patch variables.py [Checked in: 2.53.1 beta 1]

On gitlab 2.53.1 beta 1 - https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/commit/aa0f624123477e7f22a3e0e85d40a22753ca3a84
Further changes potentially in a future release
Attachment #9117547 - Attachment description: Patch variables.py → Patch variables.py [Checked in: 2.53.1 beta 1]
Blocks: 1633729

(In reply to Ian Neal from comment #3)

The other option is to backport 2nd and 4th parts of Bug 1507754, Bug 1578806 and Bug 1561782 then adapt source_repos.py for use against gitlab but perhaps that is for beta 2.
Spun this off into Bug 1633729

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.