1605729 - Extend variables.py to understand gitlab repos

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Ian Neal]

At the moment build/variables.py assumes all repos use rev to separate changeset from repo URL. gitlab uses tree

Comment 1

[Ian Neal]

Attachment: Patch variables.py [Checked in: 2.53.1 beta 1]

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: link to repo is incorrect in about:buildconfig
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9117547 [details] [diff] [review]
Patch variables.py [Checked in: 2.53.1 beta 1]

LGTM

Comment 3

[Ian Neal]

The other option is to backport 2nd and 4th parts of Bug 1507754, Bug 1578806 and Bug 1561782 then adapt source_repos.py for use against gitlab but perhaps that is for beta 2.

Comment 4

[Ian Neal]

Comment on attachment 9117547 [details] [diff] [review]
Patch variables.py [Checked in: 2.53.1 beta 1]

On gitlab 2.53.1 beta 1 - https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/commit/aa0f624123477e7f22a3e0e85d40a22753ca3a84
Further changes potentially in a future release

Comment 5

[Ian Neal]

(In reply to Ian Neal from comment #3)

The other option is to backport 2nd and 4th parts of Bug 1507754, Bug 1578806 and Bug 1561782 then adapt source_repos.py for use against gitlab but perhaps that is for beta 2.
Spun this off into Bug 1633729