Open Bug 1633729 Opened 5 years ago Updated 4 years ago

Update about:buildconfig to display comm as well as mozilla source information

Categories

(SeaMonkey :: Build Config, task)

Product:
SeaMonkey
Component:
Build Config
Type:
task

Tracking

(Not tracked)

Status:
ASSIGNED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.3)

Attachments

(4 files, 4 obsolete files)

Use local repo patch
3.95 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review
Use local repo patch for 2.57
3.95 KB, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Port and adapt v1.2 for 2.53.3
18.76 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review
Port and adapt v1.2 for 2.57
18.86 KB, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

This patch ports the changes from the following bugs:

  • Parts 2-4 of Bug 1507754 - platform.ini is incorrect - SourceRepository field points to a TB repo
  • Bug 1561782 - Display Thunderbird source code information in about:buildconfig.
  • Bug 1578806 - Build failure on macOS post bug 1507754

Then adapts source_repos.py for use with variables set to gitlab repos

Attached patch Port and adapt (obsolete) — — Splinter Review

This patch ports the changes across to SeaMonkey and adapts to deal with git as well as hg source urls.
At the moment relies on mozconfig setting relevant variables:
MOZ_GECKO_SOURCE_CHANGESET
MOZ_GECKO_SOURCE_REPO
MOZ_COMM_SOURCE_CHANGESET
MOZ_COMM_SOURCE_REPO

Followup patch/bug will look at determining that information if not set.

Attachment #9143976 - Flags: review?(frgrahl)
Attachment #9143976 - Flags: approval-comm-release?
Attachment #9143976 - Flags: approval-comm-esr60?

At the moment if the variables MOZ_SOURCE_CHANGESET and MOZ_SOURCE_REPO are not set then configure.in checks hg for the information. This patch moves the setting of the two variables out of configure.in and into source_repos.py, so if the variables are not set (and the equivalent ones for COMM) then it checks for hg and git repo information.

Attachment #9144207 - Flags: review?(frgrahl)
Attachment #9144207 - Flags: approval-comm-release?
Attachment #9144207 - Flags: approval-comm-esr60?
Attached patch Port and adapt for 2.57 (obsolete) — — Splinter Review

Version for 2.57

Attachment #9145018 - Flags: review?(frgrahl)
Attachment #9145018 - Flags: approval-comm-esr60?
Attachment #9143976 - Flags: approval-comm-esr60?
Attachment #9144207 - Flags: approval-comm-esr60?

Version for 2.57

Attachment #9145020 - Flags: review?(frgrahl)
Attachment #9145020 - Flags: approval-comm-esr60?
Attached patch Port and adapt v1.1 for 2.53.3 (obsolete) — — Splinter Review

Add checks for no gecko_repo

Attachment #9143976 - Attachment is obsolete: true
Attachment #9143976 - Flags: review?(frgrahl)
Attachment #9143976 - Flags: approval-comm-release?
Attachment #9145301 - Flags: review?(frgrahl)
Attachment #9145301 - Flags: approval-comm-release?
Attachment #9145301 - Flags: approval-comm-esr60?
Attached patch Port and adapt v1.1 for 2.57 (obsolete) — — Splinter Review

Add checks for no gecko_repo

Attachment #9145018 - Attachment is obsolete: true
Attachment #9145018 - Flags: review?(frgrahl)
Attachment #9145018 - Flags: approval-comm-esr60?
Attachment #9145302 - Flags: review?(frgrahl)
Attachment #9145302 - Flags: approval-comm-esr60?
Attachment #9145301 - Flags: approval-comm-esr60?

Make it so it works for TB too on 2.53.3 repo

Attachment #9145301 - Attachment is obsolete: true
Attachment #9145301 - Flags: review?(frgrahl)
Attachment #9145301 - Flags: approval-comm-release?
Attachment #9151252 - Flags: review?(frgrahl)
Attachment #9151252 - Flags: approval-comm-release?

Make it work for TB on 2.57 repo

Attachment #9145302 - Attachment is obsolete: true
Attachment #9145302 - Flags: review?(frgrahl)
Attachment #9145302 - Flags: approval-comm-esr60?
Attachment #9151253 - Flags: review?(frgrahl)
Attachment #9151253 - Flags: approval-comm-esr60?
Comment on attachment 9151252 [details] [diff] [review] Port and adapt v1.2 for 2.53.3 LGTM r/a + for SeaMonkey release branch
Attachment #9151252 - Flags: review?(frgrahl)
Attachment #9151252 - Flags: review+
Attachment #9151252 - Flags: approval-comm-release?
Attachment #9151252 - Flags: approval-comm-release+
Comment on attachment 9144207 [details] [diff] [review] Use local repo patch LGTM r/a + for SeaMonkey release branch
Attachment #9144207 - Flags: review?(frgrahl)
Attachment #9144207 - Flags: review+
Attachment #9144207 - Flags: approval-comm-release?
Attachment #9144207 - Flags: approval-comm-release+
Comment on attachment 9145020 [details] [diff] [review] Use local repo patch for 2.57 LGTM
Attachment #9145020 - Flags: review?(frgrahl)
Attachment #9145020 - Flags: review+
Attachment #9145020 - Flags: approval-comm-esr60?
Attachment #9145020 - Flags: approval-comm-esr60+
Comment on attachment 9151253 [details] [diff] [review] Port and adapt v1.2 for 2.57 LGTM
Attachment #9151253 - Flags: review?(frgrahl)
Attachment #9151253 - Flags: review+
Attachment #9151253 - Flags: approval-comm-esr60?
Attachment #9151253 - Flags: approval-comm-esr60+
Whiteboard: SM2.53.3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: