1606143 - Octothorpe/sharp/hash/pound marks are elided from end of searches of history

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[Florencia Di Ciocco, NI to vbalducci]

Attachment: Captura de pantalla de 2019-12-27 16-31-13.png

Steps to reproduce:

Open a new tab
In the address bar type a random string (e.g. flor) and press enter. The search is made.
Then, in a new tab or the same one, type in the address bar the same random string but ending with "#" (e.g. flor#).

Actual results:
The first historic search is shown as a suggestion, despite typing the # on the second search.

Expected results:
The historic search should not be shown once I've typed the # since it no longer matches with what I had typed in (flor is different from flor#)

Comment 1

[Florencia Di Ciocco, NI to vbalducci]

Attachment: search.mp4

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Does this have the same regression range as bug 1560228?

Comment 3

[Florencia Di Ciocco, NI to vbalducci]

Hi Ryan,

I don't know because I couldn't find the regression range of said bug. But here's the regression range of mine:

It was working properly until version 66 included. From FF67 onwards the issue is present.
Last good revision: 1312db5d495953cc6e18b16d082d06d611a21166 (2019-01-16)
First bad revision: 1db2248f441513991df17a73112ffd9cc1846846 (2019-01-17)

And here's the pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d11bb3bd81951e0e5a66bc9e3ae80ca22d2ad13f&tochange=f2f4a6eb1576cba580ee99971f5fc035cbaeeab1

Regards, Flor.

Comment 4

[Marco Bonardo [:mak]]

I think the current behavior is the correct one.
# is a special restriction character (search only titles), as such it is removed from the string before looking for results.
But it is not removed from the string sent to the search engine when pressing enter, as a result of bug 1560228 (so one can search for c# remotely).
Supporting both behaviors is not possible without something like bug 1590732 and a new UI.