1606206 - Some media telemetry will expire on 2020-01-06 when the Gecko version number increases to 74

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

+++ This bug was initially created as a clone of Bug #1570634 +++

See bug 1570634 for the previous renewal.

https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Histograms.json#9376-9453

https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Histograms.json#12142-12211

https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Histograms.json#13317-13327

https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Histograms.json#14741-14787

https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Scalars.yaml#1395-1474

Comment 1

[Dan Minor [:dminor]]

Based upon https://bugzilla.mozilla.org/show_bug.cgi?id=1506392#c4 we're removing DTLS 1.0 and 1.1 support in March 2020, so there's no reason to renew the DTLS version probe. I'll check and see if we still need the DTLS and SRTP cipher type ones: https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Histograms.json#9424-9453

The rest appear to be playback related, so I'll defer to Bryce on those.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm inclined to bring forward all the probes. Jya, I notice you're involved with a number of the probes in question, do you have any preference for what we do with those ones?

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Alastor, I see several probes have you attached to them. As above, my inclination is to move all the probes forward, but would be interested in your thoughts.

Comment 4

[Alastor Wu [:alwu]]

I would like to keep WEBVTT_TRACK_KINDS, WEB_AUDIO_BECOMES_AUDIBLE_TIME and AUTOPLAY_DEFAULT_SETTING_CHANGE.

Comment 5

[Jean-Yves Avenard [:jya]]

(In reply to Bryce Seager van Dyk (:bryce) - limited availability until 2020.01.06 from comment #2)

I'm inclined to bring forward all the probes. Jya, I notice you're involved with a number of the probes in question, do you have any preference for what we do with those ones?

I'd like to keep anything related to playback time.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Thanks. I'm clearing backlog after returning from the holidays, but will try and get a patch to preserve the relevant telemetry made up in the next few days.

Comment 7

[Dan Minor [:dminor]]

I filed Bug 1607283 to handle the WebRTC related renewals.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Breakdown of currently planned changes for non-WebRTC probes highlighted in comment 0. I'm erring on the side of including things I perceive as related to playback time.

---

Renewed:

• MEDIA_MKV_CANPLAY_REQUESTED - I want this because of ongoing requests for MKV support so we can track.
• VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE - Relates to playback time.
• VIDEO_INTER_KEYFRAME_MAX_MS - Relates to playback time.
• VIDEO_SUSPEND_RECOVERY_TIME_MS - Relates to playback time.
• VIDEO_VP9_BENCHMARK_FPS - I would like this to help assess how many users are getting sane VP9 perf.
• WEBVTT_TRACK_KINDS - Alastor requested.
• WEB_AUDIO_BECOMES_AUDIBLE_TIME - Alastor requested.
• AUTOPLAY_DEFAULT_SETTING_CHANGE - Alastor requested.

---

Not renewed:

• MEDIACACHESTREAM_LENGTH_KB
• MEDIA_PLAY_PROMISE_RESOLUTION
• AUDIO_TRACK_SILENCE_PROPORTION

I'm confirming with Alastor he doesn't want any of the probes in
https://searchfox.org/mozilla-central/rev/723e61e5f6fe36e69592b7742bc10338392e53e4/toolkit/components/telemetry/Scalars.yaml#1395-1474
then will get a patch up.

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1606206 - Renew media playback telemetry probes. r?alwu,jya

Carry forward several media telemetry probes that the media team wishes to
continue monitoring. The probes are:

• MEDIA_MKV_CANPLAY_REQUESTED - allows us to monitor if sites are trying to play
  mkv files which guides if we should improve support for such files.

The following probes are kept to help guide playback performance:

• VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE

• VIDEO_INTER_KEYFRAME_MAX_MS.

• VIDEO_SUSPEND_RECOVERY_TIME_MS

• VIDEO_VP9_BENCHMARK_FPS

• WEBVTT_TRACK_KINDS - allows us to monitor how webvtt is being used and guide
  if we should dedicate more resources to areas of webvtt.

• WEB_AUDIO_BECOMES_AUDIBLE_TIME - allows us to monitor if sites are using
  resources on audio context that are playing audio and guide if we need to
  improve perf for such cases.

• AUTOPLAY_DEFAULT_SETTING_CHANGE - allows us to monitor if users are opting out
  of our default autoplay behaviour.

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

WIP is up (now with a better commit message), will ask for data review pending approval for other folks involved with the probes.

Comment 11

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: 1606206DataReviewRequest.txt

Comment 12

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9120577 [details]
1606206DataReviewRequest.txt

# Data Collection Renewal Review 

1) Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

2) Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

data-review: r+

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58df4e6bc1b6
Renew media playback telemetry probes. r=alwu

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/58df4e6bc1b6