[Browsertime][WebRender] Orange frame still persists after the navigation has started
Categories
(Testing :: Performance, defect, P3)
Tracking
(Not tracked)
People
(Reporter: sefeng, Assigned: sefeng)
References
Details
Attachments
(1 file)
5.22 MB,
video/quicktime
|
Details |
Check around 5 seconds of the video, you can see the navigation had started, but the orange frame was still persist. This was Fenix running Moto G5. (also reproducible on Pixel 3)
This only occurs when WebRender is enabled.
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Jessie - Can you get someone on the WR android team to take a look at this? Perhaps the visual update from removing the DOM orange frame before starting the navigation is getting delayed?
For reference, browsertime uses this (browsertime/lib/core/seleniumRunner.js) to make the orange frame's removal mark the the start of a load:
const navigate = `(function() { const orange = document.getElementById('browsertime-orange'); if (orange) { orange.parentNode.removeChild(orange); } window.requestAnimationFrame(function(){ window.requestAnimationFrame(function(){ window.location="${url}"; }); }); })();`;
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Jamie: Do you think this could be related to the black screen issues we've been seeing?
Comment 3•5 years ago
|
||
It sounds plausible, yes. I'll investigate.
Sean or Randell, I've never used browsertime before. Would it be possible to give a slightly more detailed STR?
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Hi Jamie,
In latest m-c, you should be able to do ./mach browsertime --setup
, and it will install browsertime for you, please make sure the output says
ffmpeg: OK
convert: OK
compare: OK
Pillow: OK
SSIM: OK
And then you can use this command to reproduce it. You need to install the performanceTest apk to your phone, you can get it here
./mach browsertime -- --android -b firefox --firefox.android.package org.mozilla.fenix.performancetest --video true --visualMetrics true --firefox.android.intentArgument=--ez --firefox.android.intentArgument=TURBO_MODE --firefox.android.intentArgument=false --firefox.android.intentArgument=-a --firefox.android.intentArgument=android.intent.action.VIEW --firefox.android.intentArgument=-d --firefox.android.intentArgument="data:," --firefox.windowRecorder false --firefox.android.activity org.mozilla.fenix.browser.BrowserPerformanceTestActivity -n 1 https://ebay.com
Comment 5•5 years ago
|
||
We theorize this should be addressed by bug 1581868
Comment 6•5 years ago
|
||
FWIW, I don't think this is related to the black screen issue. I think it should probably be debugged separately.
Comment 7•5 years ago
|
||
I spoke too soon!
Comment 8•5 years ago
|
||
We worked around this by adding a white div behind the orange one.
Comment 9•5 years ago
|
||
Changing the priority of the bug due to workaround unblocking browsertime.
Assignee | ||
Comment 10•5 years ago
|
||
For the record, this is the workaround https://github.com/mozilla/browsertime/pull/60
Updated•4 years ago
|
Comment 11•4 years ago
|
||
:jnicol, there's an outstanding ni? in this bug from :sefeng - has it been answered?
Updated•4 years ago
|
Comment 12•4 years ago
|
||
I don't think the needinfo was asking anything, but instead was just to ensure I saw Sean's answer. So yes.
(I think I was able to reproduce using Sean's instructions, but didn't investigate any further due to the workaround.)
Assignee | ||
Comment 14•4 years ago
|
||
I removed the workaround we did in comment 10 from browsertime, and was unable to reproduce it by using the command from comment 4 against https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v2.fenix.beta.2020.09.23.latest.
So looks like this is not an issue anymore.
Updated•3 years ago
|
Comment 15•2 years ago
|
||
Can you remove the workaround from upstream browsertime?
Assignee | ||
Comment 16•2 years ago
|
||
The workaround is now removed from the upstream https://github.com/sitespeedio/browsertime/pull/1821#issuecomment-1207272316
Description
•