1606538 - Remove localised pref mailnews.account_central_page.url

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

This pref is localised for no apparent reason, all locales use the same value. The value is now wrong everywhere except en-US as we replaced .xul with .xhtml. Let's replace it with an ordinary value.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1606538-accountcentral-pref.diff

Comment 2

[Jorg K (CEST = GMT+2)]

Can't we kill the pref altogether? BTW, try_task_config.json is not something you wanted to change/add here, right?

Comment 3

[Geoff Lankow (:darktrojan)]

We could kill the pref altogether. But I don't know the reason that it is a pref in the first place. I'm assuming there is one, however stupid that assumption may be.

I knew I'd leave a try config lying around sooner or later. Let's just ignore that, yeah?

Comment 4

[Jorg K (CEST = GMT+2)]

Sure, but don't land it. Those things get overlooked. Personally, (still) using HG queues, it would be a 30 sec exercise to upload a new patch.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 9118266 [details] [diff] [review]
1606538-accountcentral-pref.diff

Review of attachment 9118266 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove the comment for the string, too.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9118266 [details] [diff] [review]
1606538-accountcentral-pref.diff

Review of attachment 9118266 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed we should just remove this pref. r=mkmelin with that

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1606538-accountcentral-pref-2.diff

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8aca29c49f29
Remove localised pref mailnews.account_central_page.url; r=mkmelin