1609037 - DoH Rollout Extension: Wait until a top-level location change to show the doorhanger

Status: VERIFIED FIXED

(Firefox :: Security, enhancement, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Currently the doorhanger is shown immediately when the add-on detects passing heuristics. Waiting for a top-level location change would be a nicer UX because:

1. It makes sense for an alert to show up after a navigation
2. It's less likely to catch a user in the middle of closing a window or tab.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1609037 - DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=dragana!

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5bf9825c5e84e01faf745ab155a28cf6d1b654b

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44539f8e0cea
DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=johannh

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_cleanFlow.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/93971c20927357c150cd5556d4055a744eecb757
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285385275&repo=autoland&lineNumber=5101

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca3381ffade1
DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=johannh

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ca3381ffade1

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9120687 [details]
Bug 1609037 - DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=dragana!

Beta/Release Uplift Approval Request

• User impact if declined: When DoH is enabled (via Normandy), "older" users (profiles created before Oct 31 2019) see the consent doorhanger at an uncontrolled time, without any interaction trigger. With the patch, the doorhanger is shown only after a navigation in the selected tab in the top window.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • In a new profile created with system time set before Oct 31 2019, enable DoH. The doorhanger should not immediately appear. The doorhanger should also not appear when there are navigations in any tabs that are not selected or not in the top window.
  • In the selected tab in the top window, perform a navigation. The doorhanger should appear.
• List of other uplifts needed: Bug 1608320, Bug 1600109
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Functionality change, so not low-risk. Covered by automated tests and QA support.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9120687 [details]
Bug 1609037 - DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=dragana!

DoH UX improvement. Approved for 73.0b8.

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

This bug is part of the DoH rollout work (to be more specific, part of the PI-445 request). Full testing phase is planned once the fix lands on beta 73.

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1766ab40038c

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out (Bug 1600109, Bug 1609037, Bug 1608320) for turning Bug 1605297 into permafail.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-browser-chrome-e10s-6%2Cwindows7-32-shippable&tochange=ca3381ffade1dcca914741a00ccba55a19b02142&group_state=expanded&fromchange=4287ea98207d8c830c876c64de5d475fdbafbc14&selectedJob=286029897

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286029897&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/42fdbe58028de404df948fab374b86c1ae4daf41

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/42fdbe58028d

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf08a3fa92e7
DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=johannh

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf08a3fa92e7

Comment 15

[Cristian Baica [:cbaica], Release Desktop QA]

Confirming this as verified fixed. The implementation has been extensively tested for PI-445 on Windows 10, Ubuntu 18.04 and macOS 10.15 using the latest beta. The doorhanger is displayed if it meets the specified requirements in the ticket.