1608320 - DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement.

Status: VERIFIED FIXED

(Firefox :: Security, task, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

For profiles created after Oct 31 2019, we would have shown to the user at first-run a version of the privacy statement that mentions DoH. For these users, we don't need to show the consent doorhanger.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1608320 - DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana!

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5acd6c62839303da8ea675614485749f1f4cb462

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dddea4c5d73
DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_cleanFlow.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/93971c20927357c150cd5556d4055a744eecb757
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285385275&repo=autoland&lineNumber=5101

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f3358db89c7
DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6f3358db89c7

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9120684 [details]
Bug 1608320 - DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana!

Beta/Release Uplift Approval Request

• User impact if declined: Newer users will see a (unnecessary) consent doorhanger even though they saw a version of the first-run privacy agreement that includes DoH
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Create a profile with system time set to a date before Oct 31 2019. Enable DoH. Doorhanger should appear. DoH heuristics should run as expected.
  Create a profile with system time set correctly. Enable DoH. Doorhanger should not appear. DoH heuristics should run as expected.
• List of other uplifts needed: Bug 1600109
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Functionality change, so not low risk. Covered by automated tests and QA support.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9120684 [details]
Bug 1608320 - DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana!

DoH UX improvement. Approved for 73.0b8.

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

This bug is part of the DoH rollout work (to be more specific, part of the PI-445 request). Full testing phase is planned once the fix lands on beta 73.

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c2bec0f6c318

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out (Bug 1600109, Bug 1609037, Bug 1608320) for turning Bug 1605297 into permafail.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-browser-chrome-e10s-6%2Cwindows7-32-shippable&tochange=ca3381ffade1dcca914741a00ccba55a19b02142&group_state=expanded&fromchange=4287ea98207d8c830c876c64de5d475fdbafbc14&selectedJob=286029897

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286029897&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/42fdbe58028de404df948fab374b86c1ae4daf41

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/42fdbe58028d

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be7f69aa2f3
DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2be7f69aa2f3

Comment 15

[Cristian Baica [:cbaica], Release Desktop QA]

Confirming this as verified fixed. The implementation has been extensively tested for PI-445 on Windows 10, Ubuntu 18.04 and macOS 10.15 using the latest beta. The doorhanger is displayed if it meets the specified requirements in the ticket.

Comment 16

[Victoria Wang [:victoria]]

Hi all, I see this dialog when running a new Firefox release 89 download with new profile. Could there have been a regression? Would appreciate if someone confirm this behavior.

Comment 17

[(inactive) Nihanth Subramanya [:nhnt11]]

What happened here was that we decided to revert this at the last minute, and ended up shipping a Normandy recipe that set the value of the pref containing the timestamp of the profile creation date threshold to a date far in the future, so that all profiles would be shown the doorhanger. Later, the entire doorhanger code was removed when we migrated to CFR. So the change to revert this bug was never tracked on Bugzilla (or even elsewhere other than Experimenter, I think).

Comment 18

[Victoria Wang [:victoria]]

Thanks for the background! I've created a new bug here.