Closed Bug 1609145 Opened 6 years ago Closed 6 years ago

grant sheriffs permissions to manage project-mobile trees, like retriggering tasks

Categories

(Release Engineering :: Firefox-CI Administration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aryx, Assigned: mtabara)

References

Details

Attachments

(4 external files)

Sheriffs shall monitor the project-mobile repositories android-components, fenix and reference-browser.

They need permissions similar to the desktop repositories (mozilla-*, autoland), e.g. to retrigger tasks, rerun and backfill them.

This requires more work: A retrigger of a task on the fenix project returns: Retrigger failed with Decision task: A0kwrUHqRFaO4Orw0DoYoQ: Error: Action is misconfigured: decision task's scopes do not satisfy in-tree:hook-action:project-mobile/in-tree-action-3-generic/9550aff72c

For backfills: Taskcluster: 'backfill' action is not available for this task. Available:

See Also: → 1609754

:mtabara could you please treat this as high priority? All Raptor perf jobs on fenix repo are failing & we don't really have other means of troubleshooting them. We're basically blind there, in terms of performance.

Flags: needinfo?(mtabara)

Sorry I didn't triage this earlier. Will take care of this. In the meantime, anyone in RelEng can help with reruns/retriggers. Me and Johan (jlorenzo) specifically in EU times.

Leaving the NI until I fix the bug.

Assignee: nobody → mtabara

Hm, unclear to me yet what needs to be done here. I see we don't have hook-actions but for XPIs and Johan's staging releases on Fenix. We might need to enrich taskgraph-actions to the mobile projects as well in order for these scopes to be generated. this

I think this is blocked indirectly by the work in bug 1610725.
Even if we grant these permissions, the actual action tasks don't exist, AFAIK.

Depends on: 1610725

Removing the NI here, current status:

  • we're working on adding support for sheriffs to add them rights to trigger on-demand Raptor tests for Fenix bug 1610751
  • work in progress in bug 1610725 to unblock this current bug in order to allow them to Add jobs via Treeherder too in the near future.
Depends on: 1610751
Flags: needinfo?(mtabara)

Can this land?

Flags: needinfo?(mozilla)

It looks like everything here has landed, but that doesn't include granting sherrifs the permission to trigger actions.

Flags: needinfo?(mozilla)

This enables a few things:

  • managing mobile-specific workers
  • cancelling and re-running tasks from the CLI
  • triggering non-relpro actions on trees

I also created https://github.com/mozilla-mobile/fenix/pull/8976 to default to retriggers for test jobs (like we do on m-c). We should probably do the same of the other trees that sheriffs will monitor.

Flags: needinfo?(mtabara)

This makes sense to me. Other trees like the rest of mobile projects you mean? (mainly thinking of AC)

Flags: needinfo?(mtabara)

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #14)

This makes sense to me. Other trees like the rest of mobile projects you mean? (mainly thinking of AC)

Yeah, and perhaps reference browser? I'm not sure exactly what repos sherrifs are (going to be?) monitoring.

(In reply to Tom Prince [:tomprince] from comment #15)

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #14)

This makes sense to me. Other trees like the rest of mobile projects you mean? (mainly thinking of AC)

Yeah, and perhaps reference browser? I'm not sure exactly what repos sherrifs are (going to be?) monitoring.

I think they monitor all you've mentioned. Let's bring in :Aryx to the conversation to get some of the input.
@aryx: just to confirm, are Sheriffs monitoring all these repositories actively: ref-browser, android-components, Fenix? Are there more of the github projects that they actively monitor? If so, we should enrich Tom's patch to also encompass the rest of the repos so that they have more power and can self-serve.

Flags: needinfo?(aryx.bugmail)

The plan is to have android-components, fenix and reference-browser sheriffed (at the moment I am doing it). Currently I am not aware of more projects to get sheriffed.

Flags: needinfo?(aryx.bugmail)

AFAIK this is done, more details in bug 1631834 too.
I think we can close this. Please reopen if I'm wrong.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
See Also: → 1631834
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: