maybeReloadEngines should not rebuild the entire engine list, only handle new/update/remove of engines
Categories
(Firefox :: Search, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
maybeReloadEngines
currently assumes that the entire engine list is going to change. That is not usually the case, and ends up with doing more work than necessary, including writing to the cache.
Ideally we should only add or remove engines from the existing list. For the modern configuration we also need to remember to handle engine updates where the configuration has actually changed.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Depends on D82942
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D83123
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D83124
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Also note: I intentionally haven't read from the cache for maybeReloadEngines
in the new version. Existing engines already have the cached information stored within them, and the engine's settings don't overwrite that. Hence, we really don't need to read the cache here.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db308be7d25e Split out delay region notification test to separate test file, so that test_reload_engines can concentrate on testing the reload engines function. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/9c01746f3b05 Rewrite maybeReloadEngines to not completely reload the search engines. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/c4388ff019db When reloading engines, ensure useDBForOrder isn't set, and handle more cases of updating engines. r=daleharvey
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db308be7d25e
https://hg.mozilla.org/mozilla-central/rev/9c01746f3b05
https://hg.mozilla.org/mozilla-central/rev/c4388ff019db
Assignee | ||
Updated•4 years ago
|
Description
•