1613182 - Investigate dropping the option to wait on the region request

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

The Search Service initialisation code has a facility whereby the region and ABSearch checks can either be waited for, or started but not waited on.

This currently leads to a lot of complexity in the initialisation routines, that make it hard to reason about them and know exactly what's happening.

With some of the planned changes, I think we can simplify this and change initialisation to start the region check (if necessary), and not provide a facility to wait for it. I think we can do this because:

• Modernisation is removing the ABSearch part with Remote Settings, and Remote settings will trigger an update as necessary.
• Bug 1610293 is proposing to rewrite maybeReloadEngines to make it simpler, and only make changes to the engines list and defaults where necessary.
• The above rewrite means we'll better handle any changes on initial startup, with decreased load for any UI trying to render the engines.
• We'll also no longer block at all on the region check, providing better functionality faster.
• Any tests should be able to be rewritten to wait as necessary for the various parts to complete before checking the results.

Comment 1

[Mark Banner (:standard8)]

Bug 1627541 has fixed this.