1610741 - Move Network Settings section from General into Privacy and Security, and move DoH out of the proxy dialog.

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

This is intended to land in 75.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1610741 - Move Network Settings into Privacy and Security section. r=johannh!

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

This was deprioritized.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1610741 - DoH setting UI r=kershaw

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1610741 - Remove old DoH UI r=Gijs

Depends on D172966

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1610741 - DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw

• The patch saves the confirmation channel's status and skipReason in the TRR Service
• The UI queries the status and displays the stringified version in the Not Available (reason) label
• Introduces doh-status-label CSS rule so the Learn-More link isn't off center

Depends on D173940

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1610741 - Allow setting invalid URL in TRRService and show it in settings r=kershaw,Gijs

• Patch changes TRRService::MaybeSetPrivateURI so that it doesn't bail
  if the URL is invalid. That could lead us into a state where the
  network.trr.uri pref has been set to some invalid URL, but we continue
  using the previous domain (or even the default TRR provider) instead.
• Updates the DoH settings UI to not set the network.trr.uri pref to "",
  as that will cause the TRRService to use the value of
  the network.trr.default_provider_uri pref instead.

Depends on D174110

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1610741 - Update warning message in DoH warning pages r=flod

Depends on D173942

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f296319409a
DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
https://hg.mozilla.org/integration/autoland/rev/44218f91e7cf
Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e9e331ccc7ab
DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e2e564f584b3
Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/8596bc4554df
Update warning message in DoH warning pages r=flod,fluent-reviewers

Comment 9

[Cristian Tuns]

Backed out for causing xpcshell failures in test_dooh.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_dooh.js | Test timed out

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec3cfe29b61
DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
https://hg.mozilla.org/integration/autoland/rev/403f22e3a0a0
Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/b9b738076d55
DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/8e85f984f46c
Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/a7341379f263
Update warning message in DoH warning pages r=flod,fluent-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8ec3cfe29b61
https://hg.mozilla.org/mozilla-central/rev/403f22e3a0a0
https://hg.mozilla.org/mozilla-central/rev/b9b738076d55
https://hg.mozilla.org/mozilla-central/rev/8e85f984f46c
https://hg.mozilla.org/mozilla-central/rev/a7341379f263

Comment 12

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages on TRRService.cpp.

Push with failures: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=335d0840e3ddeeae91abcbad0bee29d13fe26617&selectedTaskRun=OqvioAMaSiuQ9iXwId3X2Q.0

Failure logs: https://treeherder.mozilla.org/logviewer?job_id=411639150&repo=mozilla-central

Backout link: https://hg.mozilla.org/integration/autoland/rev/95e453c44af9440d05ffb65b1a2878694cb20564

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1cecb2463d2
DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
https://hg.mozilla.org/integration/autoland/rev/ce7622cbeb2c
Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/525ec1a5f160
DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/f8d25be1be03
Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/57c51f48ee34
Update warning message in DoH warning pages r=flod,fluent-reviewers

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c1cecb2463d2
https://hg.mozilla.org/mozilla-central/rev/ce7622cbeb2c
https://hg.mozilla.org/mozilla-central/rev/525ec1a5f160
https://hg.mozilla.org/mozilla-central/rev/f8d25be1be03
https://hg.mozilla.org/mozilla-central/rev/57c51f48ee34

Comment 15

[Pascal Chevrel:pascalc]

Valentin, could you request a release note addition for this feature for our Nightly release notes? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla

Comment 16

[Valentin Gosu [:valentin] (he/him)]

I made a similar request in bug 1596847.

(In reply to Valentin Gosu [:valentin] (he/him) from bug 1596847 comment #13)

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds more advanced UI for controlling DoH settings to avoid having users set about:config prefs.
[Affects Firefox for Android]: No
[Suggested wording]:

Bug 1610741 moved the DNS over HTTPS settings to the Privacy & Security section of the settings page and allows the user to choose from all the supported modes. Bug 1596847 added UI to manage the DNS over HTTPS exception list.

[Links (documentation, blog post, etc)]: DoH UI Improvements project plan

Comment 17

[Pascal Chevrel:pascalc]

Note added to Nightly 114 release notes in the CHANGED section with this wording:

DNS over HTTPS settings are now part of the Privacy & Security section of the Settings page and allow the user to choose from all the supported modes.

Comment 18

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9323867 [details]
Bug 1610741 - DoH setting UI r=kershaw

Beta/Release Uplift Approval Request

• User impact if declined: Users will receive the DoH settings UI in Fx 114 instead of Fx 113
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA is in progress: https://mozilla-hub.atlassian.net/browse/QA-1817
• List of other uplifts needed: Bug 1596847, Bug 1826749
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We have identified some edgecases in bug 1826749 and fixes are currently waiting for review; QA has identified bug 1825538 (proxies might not work when DoH strict mode is enabled). The main risks would be shipping the UI without these fixes. I think the risk of major bugs with the UI implementation is low.
• String changes made/needed: Yes. Strings in preferences.ftl, permissions.ftl, netError.ftl were added.
• Is Android affected?: No

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9323867 [details]
Bug 1610741 - DoH setting UI r=kershaw

Per discussion with the various stakeholders, this is going to ride the 114 train.