Closed Bug 1611006 Opened 4 years ago Closed 4 years ago

Convert mozbuild/test/action/* to Python 3

Categories

(Firefox Build System :: General, task)

task
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

No description provided.
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ed03cb85dcf
Convert python/mozbuild/mozbuild/test/action to python3; r=firefox-build-system-reviewers,rstewart
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Backed out for nightly bustages

backout: https://hg.mozilla.org/mozilla-central/rev/a4ef54d57737f24d2542187a3d0c627e5d28b24b

push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=a170089a8a033b5a2d8bba365656965aebe3a444&searchStr=nightly&group_state=expanded&selectedJob=286326418

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286325451&repo=mozilla-central&lineNumber=7076

[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - if aLine == '\n':
[task 2020-01-24T11:23:42.974Z] 11:23:42 ERROR - Traceback (most recent call last):
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - "main", fname, loader, pkg_name)
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - exec code in run_globals
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 489, in <module>
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - main(sys.argv[1:])
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 483, in main
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - chrome_entries
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 388, in create_webmanifest
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - defines['MOZ_LANGPACK_CONTRIBUTORS'] if 'MOZ_LANGPACK_CONTRIBUTORS' in defines else ""
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 179, in build_author_string
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - contrib = convert_contributors(contributors)
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 151, in convert_contributors
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - str = str.replace('<em:contributor>', '')
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 16: ordinal not in range(128)
[task 2020-01-24T11:23:42.980Z] 11:23:42 INFO - /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:220: recipe for target 'package-langpack-fa' failed
[task 2020-01-24T11:23:42.980Z] 11:23:42 ERROR - make[1]: *** [package-langpack-fa] Error 1
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - Makefile:106: recipe for target 'installers-fa' failed
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - make: *** [installers-fa] Error 2
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - Return code: 2
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - make installers-fa failed
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - failure: repack_locale(fa)

Status: RESOLVED → REOPENED
Flags: needinfo?(mshal)
Resolution: FIXED → ---
See Also: → 1610944
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6851f568b173
Convert python/mozbuild/mozbuild/test/action to python3; r=firefox-build-system-reviewers,rstewart
Flags: needinfo?(mshal)
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED

Backed out changeset 6851f568b173 (Bug 1611006) for causing nightly bustages a=backout

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=fc760793ad44d712a066265c6c11b82aad450055

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287029496&repo=mozilla-central&lineNumber=20013

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b3fedfc4923c4be5724fcccb8acbe253792ec11d

[task 2020-01-31T00:57:37.753Z] 00:57:37     INFO -  z:/task_1580430903/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/task_1580430903/build/src/config/nsinstall.py -D ../../dist/win32/xpi/
[task 2020-01-31T00:57:37.816Z] 00:57:37     INFO -  z:/task_1580430903/build/src/obj-firefox/_virtualenvs/init_py3/Scripts/python.exe -m mozbuild.action.langpack_manifest --locales ar --min-app-ver 74.0a1 --max-app-ver 74.0a1 --app-name 'Firefox Nightly' --l10n-basedir 'z:/task_1580430903/build/l10n' --defines z:/task_1580430903/build/l10n/ar/toolkit/defines.inc z:/task_1580430903/build/l10n/ar/browser/defines.inc  --langpack-eid 'langpack-ar@firefox.mozilla.org' --input ../../dist/xpi-stage/locale-ar
[task 2020-01-31T00:57:38.042Z] 00:57:38    ERROR -  Traceback (most recent call last):
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -    File "C:\mozilla-build\python3\Lib\runpy.py", line 193, in _run_module_as_main
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -      "__main__", mod_spec)
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -    File "C:\mozilla-build\python3\Lib\runpy.py", line 85, in _run_code
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -      exec(code, run_globals)
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -    File "z:\task_1580430903\build\src\python\mozbuild\mozbuild\action\langpack_manifest.py", line 489, in <module>
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -      main(sys.argv[1:])
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -    File "z:\task_1580430903\build\src\python\mozbuild\mozbuild\action\langpack_manifest.py", line 462, in main
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -      defines = parse_defines(args.defines)
[task 2020-01-31T00:57:38.042Z] 00:57:38     INFO -    File "z:\task_1580430903\build\src\python\mozbuild\mozbuild\action\langpack_manifest.py", line 128, in parse_defines
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -      pp.do_include(path)
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -    File "z:\task_1580430903\build\src\python\mozbuild\mozbuild\preprocessor.py", line 836, in do_include
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -      for l in args:
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -    File "z:\task_1580430903\build\src\obj-firefox\_virtualenvs\init_py3\lib\encodings\cp1252.py", line 23, in decode
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -      return codecs.charmap_decode(input,self.errors,decoding_table)[0]
[task 2020-01-31T00:57:38.043Z] 00:57:38     INFO -  UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 508: character maps to <undefined>
[task 2020-01-31T00:57:38.059Z] 00:57:38     INFO -  z:/task_1580430903/build/src/toolkit/locales/l10n.mk:220: recipe for target 'package-langpack-ar' failed
[task 2020-01-31T00:57:38.059Z] 00:57:38     INFO -  mozmake.exe[1]: *** [package-langpack-ar] Error 1
[task 2020-01-31T00:57:38.059Z] 00:57:38     INFO -  mozmake.exe[1]: Leaving directory 'z:/task_1580430903/build/src/obj-firefox/browser/locales'
[task 2020-01-31T00:57:38.060Z] 00:57:38     INFO -  Makefile:106: recipe for target 'installers-ar' failed
[task 2020-01-31T00:57:38.060Z] 00:57:38     INFO -  mozmake.exe: *** [installers-ar] Error 2
[task 2020-01-31T00:57:38.061Z] 00:57:38    ERROR - Return code: 2
[task 2020-01-31T00:57:38.061Z] 00:57:38    ERROR - make installers-ar failed
[task 2020-01-31T00:57:38.061Z] 00:57:38    ERROR - failure: repack_locale(ar)
[task 2020-01-31T00:57:38.061Z] 00:57:38    ERROR - # TBPL FAILURE #
[task 2020-01-31T00:57:38.061Z] 00:57:38  WARNING - setting return code to 2
[task 2020-01-31T00:57:38.061Z] 00:57:38     INFO - Copying z:\task_1580430903\build\src\browser/config/mozconfigs/win32/l10n-mozconfig to z:\task_1580430903\build\src/.mozconfig
[task 2020-01-31T00:57:38.061Z] 00:57:38     INFO - Reading from file z:\task_1580430903\build\src/.mozconfig
Status: RESOLVED → REOPENED
Flags: needinfo?(mshal)
Resolution: FIXED → ---
Target Milestone: mozilla74 → ---

Ricky spun off the preprocessor issue into bug 1613263, so once that lands we should be able to re-land this (3rd time's a charm?)

Depends on: 1613263
Flags: needinfo?(mshal)

It's green on try now that the preprocessor bug landed. Hopefully this works...

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fa3425acef2
Convert python/mozbuild/mozbuild/test/action to python3; r=firefox-build-system-reviewers,rstewart
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: