1611882 - Unable to verify OTR fingerprint

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Rob Lemley [:rjl]]

Attachment: VerifyContact.png

Disclaimer, this is a try build but I expect it would be a problem on a regular daily build as well. 74.0a1 (2020-01-28) (64-bit)

When using OTR with IRC, I'm not able to verify the peer's fingerprint in Thunderbird.

To reproduce:

• Start a conversation with someone over IRC. Encryption status says "Insecure".
• Click the encryption button, select "Start encrypted conversation". The other end indicates that the connection has gone secure and Thunderbird has the message to Verify contact's fingerprint. (See screenshot, there's a UI/CSS problem here too)
• Encryption status now says "Unverified"
• Click the "Unverified" button and select "Verify your contact's identity"

Expected:

• The otr-auth dialog should show
  Actual:
• Broken XUL dialog. See screenshot.

Comment 1

[Rob Lemley [:rjl]]

Attachment: OtrAuthBrokenDialog.png

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1611882-fix-otr-auth.patch

Fallout of bug 1597964.
I haven't tested this. How do I enable OTR in chat?

Comment 3

[Rob Lemley [:rjl]]

I can confirm that this patch fixes the otr-auth dialog.
(You need to enable chat.otr.enable in about:config and make sure you have libotr and its dependencies installed. https://wiki.mozilla.org/Thunderbird:OTR)

Comment 4

[Magnus Melin [:mkmelin] (away, back June 30)]

Comment on attachment 9123255 [details] [diff] [review]
1611882-fix-otr-auth.patch

Review of attachment 9123255 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd978b04bcee
Fix XML parsing error in "OTR auth". r=mkmelin

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 73.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/23b28595c244282bfafed736048e9d48e5b92033